52107 Commits
Author SHA1 Message Date
Matthias Grob 9a4fef9c02 build(style): check parameter member naming convention in check_format
Parameter accessing members should according to convention be named _param_{lower case parameter name} so full text search reveals all use of a value in the code.
Nothing enforced it, and 429 members drifted into violating the convention.

There was a script to rename them once which got replaced with a new one to allow checking (in CI) to enforce the naming.
2026-11-18 18:40:12 +01:00
Ramon Roche 30621ae2c3 ci(build-all): bump voxl2 container to v1.8
The v1.7 image is Ubuntu 20.04 with Python 3.8.10. pymavlink's mavgen
now calls int.bit_count(), which needs Python 3.10, so the VOXL2 build
fails as soon as the mavlink submodule is updated (#29865):

  AttributeError: 'int' object has no attribute 'bit_count'

v1.8 keeps ModalAI's base image and Hexagon SDK and adds Python 3.12
in a venv that is first on PATH. That is the same minor version as
the main px4-dev container.

Assisted-by: Claude:claude-fable-5-2
Signed-off-by: Ramon Roche <mrpollo@gmail.com>
2026-11-18 09:03:31 -08:00
Andrea Bernasconi b2343f6b62 build(containers): use native astyle in the ROS images
astyle-py 1.1.0 requires PyYAML~=6.0.1, which conflicts with the distro
PyYAML 5.4.1 that the ROS humble image pins as a pip constraint, so the
image build fails with ResolutionImpossible. Install the distro astyle
(3.1 on jammy and noble, accepted by fix_code_style.sh) and leave
astyle-py out of the requirements installed in the ROS images.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Andrea Bernasconi <andrea.bernasconi@auterion.com>
2026-11-18 08:23:56 -08:00
Matthias Grob 3d820c5e80 build(astyle): pin astyle 3.1 via astyle-py
Distros ship newer astyle versions (Ubuntu 26.04: 3.6) which are
incompatible with our options and format differently, so make
check_format failed out of the box and required manually installing
an old .deb. astyle-py bundles astyle 3.1 as WebAssembly and installs
via pip on any OS, giving byte-identical results to native 3.1.

Native astyle 2.06-3.1 is still accepted as fallback, so existing
setups and the current CI container keep working.

Files are now formatted in batches on a temporary copy instead of one
astyle call per file, which keeps make check_format fast despite the
interpreter startup.
2026-11-18 08:23:56 -08:00
Matthias Grob 1d85a376f9 refactor(px4io_protocol): keep crc8_tab[] private to the library 2026-11-18 16:50:02 +01:00
Matthias Grob 3bc7dcd7ad refactor(src/lib): make CMakeLists alphabetical again 2026-11-18 16:50:02 +01:00
Michael Rogov Papernov 554f60d6fd refactor(px4io): move protocol.h into px4io_protocol lib
Drivers and arch code no longer include a header from inside the IO
firmware module.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Michael Rogov Papernov <michael@membrowse.com>
2026-11-18 16:50:02 +01:00
Michael Rogov Papernov ae65871922 refactor(px4io): share one CRC-8 table between driver and IO firmware
crc8_tab and crc_packet() were static in protocol.h, so every flight
controller image carried two copies of the table: one for the px4io
driver and one for the arch serial code.

Move them into a px4io_protocol library. This saves 304 bytes of FLASH
on px4_fmu-v6x; the IO firmware is unchanged.

Assisted-by: Claude:claude-fable-5-1
Signed-off-by: Michael Rogov Papernov <michael@membrowse.com>
2026-11-18 16:50:02 +01:00
PX4BuildBot a1e336967d docs: auto-sync metadata [skip ci]
Co-Authored-By: PX4 BuildBot <bot@px4.io>
2026-11-18 15:26:14 +00:00
Jonas Perolini baa4742bad feat(vtol_att_control): detect pusher failures in multicopter mode (#29631)
Assisted-by: Codex
2026-11-18 16:18:48 +01:00
Lim Jooyoung 6ab798c1f2 fix(rover): use the deceleration limit when the setpoint changes sign (#29832)
* fix(rover): use the deceleration limit when the setpoint changes sign

throttleControl() and speedControl() chose between the acceleration and
deceleration limits by comparing magnitudes only. A larger setpoint of
opposite sign, e.g. full reverse while driving forwards, therefore used
the acceleration limit for the whole manoeuvre, including braking
towards zero.

Treat braking towards zero for an opposite-sign setpoint as a
deceleration. In speedControl() this ends once the measured speed or the
rate limited setpoint has changed sign, so a lagging speed estimate does
not keep the deceleration limit after the rate limited setpoint has
crossed zero. Without a deceleration limit the previous behaviour is
kept.

Fixes #29727

Assisted-by: Claude:claude-opus-5-5

* refactor(rover): define the acceleration case directly

Replace the braking flag in throttleControl() and speedControl() with a
single accelerating condition, so that any case that is not accelerating
uses the deceleration limit. The selected limit is unchanged.

Add the case of a smaller setpoint of the same sign to the speedControl()
test.

Assisted-by: Claude:claude-opus-5-5
2026-11-18 15:25:47 +01:00
PX4BuildBot b65610b7bd docs: auto-sync metadata [skip ci]
Co-Authored-By: PX4 BuildBot <bot@px4.io>
2026-11-18 14:03:24 +00:00
Matthias Grob 96075cb00c fix(mag_bias_estimator): disable the mag bias estimator by default (#29342)
* fix(mag_bias_estimator): disable the mag bias estimator by default

It only helps if you have a very bad or no calibration in the first place or if the vehicle has magnets everywhere.
But it causes problems if you have a perfectly fresh calibration and no new disturbance
especially of course if the estimator runs twice, once on the can node, once on the autopilot.

* fix(mag_bias_estimator): remove the mag bias estimator from all cannodes

It will cause issues if the can nodes run their own online calibration and the autopilot expects to receive raw data. It's not super obvious but will lead to inaccuracies, drifts and inconsitencies in magnetometer heading.
2026-11-18 14:43:26 +01:00
Matthias Grob 79feb2e3f4 fix(commander): hide remaining legacy health texts from event-aware GCS (#29866)
Whenever the overall health/arming result changes, commander re-runs all
checks with the legacy mavlink_log publication and re-sends the
STATUSTEXT of every check that is still failing. Ground stations that
support events only drop these duplicates if the text starts with
"Preflight" or ends with a tab, so latched failures were shown again
each time an unrelated check changed.

Append the tab to the texts that duplicate an event but lacked it, as
described in docs/en/concept/events_interface.md:
- geofence violations (distance, altitude, custom fence)
- motor under/overcurrent and "not all ESCs armed"
- high ESC temperature
2026-11-18 14:30:44 +01:00
PX4BuildBot 269554ad7c docs: auto-sync metadata [skip ci]
Co-Authored-By: PX4 BuildBot <bot@px4.io>
2026-11-18 12:59:45 +00:00
Marco Hauswirth c863a4c0f1 refactor(ekf2): publish optical flow topics from OpticalFlowSource like AGP 2026-11-18 13:52:41 +01:00
Marco Hauswirth 8aada67965 refactor(ekf2): move the optical flow publications into OpticalFlowSource 2026-11-18 13:52:41 +01:00
Marco Hauswirth 3bd1839a72 feat(ekf2): support up to two optical flow sensors 2026-11-18 13:52:41 +01:00
bresch 95c82e84ea fix(ekf2): only save a mag bias observed by yawing
A mag bias reset that keeps the heading attributes the whole field
error to the bias, and its variance then converges without any
rotation. The bias is now only offered to the mag calibration once the
heading has changed by 90 degrees since its last reset.

Assisted-by: Claude:claude-fable-5-2
Signed-off-by: bresch <brescianimathieu@gmail.com>
2026-11-18 12:27:56 +01:00
bresch 5c831c9e1f test(ekf2): start GNSS after an in-flight mag loss
The heading stays aligned when the mag stops in flight, so GNSS starts
against a heading that may have drifted. A 60 degree error is corrected
by the GNSS fusion, a reversed heading by a yaw emergency reset.

Assisted-by: Claude:claude-fable-5-2
Signed-off-by: bresch <brescianimathieu@gmail.com>
2026-11-18 12:27:56 +01:00
bresch 24aafe12b7 test(ekf2): make the simulated GNSS position follow the trajectory
The trajectory only set the GNSS velocity, so the position stayed
fixed and contradicted it as soon as both were fused.

Assisted-by: Claude:claude-fable-5-2
Signed-off-by: bresch <brescianimathieu@gmail.com>
2026-11-18 12:27:56 +01:00
bresch 8bc38e0711 fix(ekf2): keep the yaw alignment when the mag stops in flight
When the mag fusion stopped without North-East aiding, the yaw
alignment was cleared and the heading reset to the mag when it came
back, also in flight. As for GNSS yaw, the alignment is now only
cleared before takeoff, and never after a manual heading.

Assisted-by: Claude:claude-fable-5-2
Signed-off-by: bresch <brescianimathieu@gmail.com>
2026-11-18 12:27:56 +01:00
bresch b408535e76 fix(ekf2): remove the manual heading expiry
The manual heading flag expired after 30 s of heading fusion to allow
heading resets to the mag again. In flight those resets are gone, so
the flag now stays set and keeps protecting the heading on the ground.

Assisted-by: Claude:claude-fable-5-2
Signed-off-by: bresch <brescianimathieu@gmail.com>
2026-11-18 12:27:56 +01:00
bresch d9855bcd76 fix(ekf2): keep the heading on in-flight WMM updates
A WMM update without North-East aiding reset the heading to the mag
and zeroed the learned mag bias, also in flight. The heading is now
only reset on the ground; in flight the bias absorbs the declination
change and the heading converges by yawing.

Assisted-by: Claude:claude-fable-5-2
Signed-off-by: bresch <brescianimathieu@gmail.com>
2026-11-18 12:27:56 +01:00
bresch e8c86e287f fix(ekf2): keep the heading when the mag fusion fails
Without North-East aiding, a mag rejected for 7 s reset the heading to
the measured field, so a disturbed or wrongly rotated mag made the
heading jump in flight. The mag states now absorb the error instead.

Assisted-by: Claude:claude-fable-5-2
Signed-off-by: bresch <brescianimathieu@gmail.com>
2026-11-18 12:27:56 +01:00
PX4BuildBot 9e34d7bba1 docs: auto-sync metadata [skip ci]
Co-Authored-By: PX4 BuildBot <bot@px4.io>
2026-11-18 10:13:41 +00:00
bresch 5df4249fe4 feat(land_detector): detect movement from the aided velocity
The IMU tests cannot see motion at constant speed, which an aided
velocity estimate does.
2026-11-18 11:05:45 +01:00
bresch 745d4c4c8a feat(land_detector): detect movement from the specific force change
The vibration metrics miss smooth accelerations such as a fixed-wing
takeoff roll, which let at_rest be declared while moving.
2026-11-18 11:05:45 +01:00
Matthias Grob eaff7221eb feat(failure_detector): pause the tilt check after a VTOL skips the back-transition
Replaying about 150 logs found false positives only on standard VTOLs
after a quad-chute, with the tilt error above 60° for up to 1.75 s
while recovering from fixed-wing flight in multicopter mode.

All VTOL types switch to multicopter without back-transition on a
quad-chute, detected or commanded, and when a front transition is
aborted. The check now pauses for 5 s after such a switch instead of
raising the threshold for all VTOLs, so it protects the rest of the
multicopter flight.
2026-11-18 11:02:27 +01:00
Matthias Grob b5e65cfbfd feat(airframes): keep the tilt failure check enabled on the omnicopter
The tilt check compares against the attitude setpoint, which the
omnicopter publishes and tracks at any orientation, including upside
down. Disabling the check is no longer needed for it to fly.
2026-11-18 11:02:27 +01:00
Matthias Grob fa877566a4 feat(failure_detector)!: rename the tilt parameters to FD_TILT_ERROR
The tilt check limits the error from the attitude setpoint, which the
FD_FAIL_R name no longer describes. FD_FAIL_R becomes FD_TILT_ERROR,
now a float, and FD_FAIL_R_TTRI becomes FD_TILT_ERROR_T.

The old roll and pitch limits and trigger times meant something else,
so they start at the new defaults instead of being taken over. Only a
check disabled for both roll and pitch stays disabled, as -1.
2026-11-18 11:02:27 +01:00
Matthias Grob 8225bb350f test(failure_detector): add tilt failure check unit tests
Cover the tilt error check: threshold in all directions, error relative
to the attitude setpoint, yaw ignored, fallback to level with a stale
setpoint, disabling, trigger time and its reset, and the tailsitter
fixed-wing frame.

Also make the altitude loss tests independent of each other: the
fixture set parameters after the detector had read them on
construction, so each test ran with the previous test's values. Both
fixtures are now the detector's parameter parent, like Commander, and
apply parameters with updateParams().
2026-11-18 11:02:27 +01:00
Matthias Grob ce4da9af8f refactor(failure_detector): run the tilt trigger time on the attitude timestamp
This allows for easy time abstracted unit testing.
2026-11-18 11:02:27 +01:00
Matthias Grob 15abdd0946 feat(failure_detector)!: check tilt error against the attitude setpoint
Checking the absolute tilt from level conflicts with the vehicle's own
tilt limits: the threshold can be set below the maximum tilt, and
external modes that tilt further than the autopilot's limits trip the
check, so they can't benefit from its crash detection.

Compare the tilt with the attitude setpoint's tilt instead, falling back
to level without a recent setpoint, e.g. on rovers. Before arming the
setpoint is level, so a vehicle lying on its side still can't arm. The
tailsitter transition exception is no longer needed because the
transition setpoint is in the multicopter frame. The default trigger
time goes from 0.3 s to 1 s so that fixed-wing stick reversals, which
pass through a large error at a limited roll rate, don't trigger it.

Also reset the tilt hysteresis while attitude control is off, so a
pending trigger from before e.g. Acro can't skip the trigger time when
attitude control comes back on.
2026-11-18 11:02:27 +01:00
Matthias Grob 7f83c28400 feat(failure_detector)!: check tilt instead of roll and pitch separately
Checking roll and pitch against separate limits misses a combined
tilt: 45° roll with 45° pitch is a 60° tilt but stays below both
default 60° limits. Euler angles are also unreliable near 90° pitch
and when inverted.

FD_FAIL_R and FD_FAIL_R_TTRI now set the maximum tilt and its trigger
time. FD_FAIL_P and FD_FAIL_P_TTRI are removed without migration
(see the Upgrade Guide). The check is disabled with -1; 0 still
disables it for existing setups. In FailureDetectorStatus, fd_roll
and fd_pitch are replaced by fd_tilt.
2026-11-18 11:02:27 +01:00
Federico MagriandSilvan Fuhrer f1dae4865c fix(fw): disable deflection scaling when landed (#29842)
* fix(fw): disable deflection scaling when landed

* Update src/modules/fw_rate_control/FixedwingRateControl.cpp

Co-authored-by: Silvan Fuhrer <silvan@auterion.com>

---------

Co-authored-by: Silvan Fuhrer <silvan@auterion.com>
2026-11-18 10:17:52 +01:00
PX4BuildBot 9db647d5d3 docs: auto-sync metadata [skip ci]
Co-Authored-By: PX4 BuildBot <bot@px4.io>
2026-11-18 09:12:00 +00:00
Jonas Perolini bab12fc267 fix(navigator): RTL type 6 keeps Home over a farther rally point (#29812)
When the battery estimate did not reach Home, type 6 took the closest
rally point even when it was farther away than Home. Return compares
destinations only by straight-line distance, so it has no reason to
prefer a rally point that is farther away than Home, and return.md says
type 6 falls back to Home unless a rally point is closer. Returns
started by the distance-aware battery failsafe hit this case.

Compare the rally points with the distance to Home, as type 6 already
does without a battery estimate.

Assisted-by: Claude:claude-opus-5-5

Signed-off-by: jonas <jonspero@me.com>
2026-11-18 10:05:33 +01:00
PX4BuildBot bd06ff372a docs: auto-sync metadata [skip ci]
Co-Authored-By: PX4 BuildBot <bot@px4.io>
2026-11-18 08:45:36 +00:00
Andrea BernasconiandAnil Kircaliali 70a735246f fix(failsafe): let GNSS loss recover during the Hold delay (#29814)
* fix(failsafe): allow GNSS loss to recover during the Hold delay

A GNSS failure that clears during the COM_FAIL_ACT_T Hold still latched
Return or Land, because COM_GNSSLOSS_ACT uses the OnModeChangeOrDisarm
clear condition. The vehicle then abandoned a mission it could have
continued.

If the failure clears while the vehicle is still holding, the action is
dropped and the user-intended mode continues, e.g. the mission resumes.
Once Return or Land has started, it stays latched as before. With
COM_FAIL_ACT_T=0 there is no Hold, so nothing changes.

Assisted-by: Claude:claude-opus-5-5

* fix(failsafe): restart the Hold delay after a failure clears during it

When a failsafe cleared during its Hold delay, the remaining delay kept
counting down. A new failure within that time did not reload it and only
got what was left, so it could Return almost without a Hold.

Reset the delay once no failsafe is pending, so that the next failure
gets the full COM_FAIL_ACT_T again. This applies to every failsafe.
Repeated failures still escalate: the start delay shrinks while a Hold
is active and refills at a quarter of that rate.

Assisted-by: Claude:claude-opus-5-5

* revert(failsafe): keep the remaining Hold delay after a failure clears

This reverts commit 5e9a8e8a14.

Restarting the delay for every new failure changed how a flapping
condition is handled, for every failsafe and not only GNSS. Without the
reset, a failure that comes back keeps the delay left over from the
previous one, so the action still fires on time. With it, only the start
delay escalation limits the flapping, which can take much longer, or
never fire if the condition is active less than a fifth of the time.

Keep the PR scoped to letting GNSS loss recover during the Hold.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Andrea Bernasconi <andrea.bernasconi@auterion.com>

* fix(failsafe): only clear GNSS loss during the Hold delay before Return starts

_current_delay is shared between failsafes. If another failsafe with a
delay is added on the same update as GNSS recovers, it re-arms the delay
and the GNSS Return or Land that was already running got removed.

Also require that the selected action is not beyond Hold yet.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Andrea Bernasconi <andrea.bernasconi@auterion.com>

---------

Signed-off-by: Andrea Bernasconi <andrea.bernasconi@auterion.com>
Co-authored-by: Anil Kircaliali <anil.kircaliali@auterion.com>
2026-11-18 09:38:57 +01:00
52c4777580 docs(boards): add Accton Godwit G-FH7 flight controller page (#28830)
* Add new board "accton_godwit gfh7"

* Adjust the spacing.

* docs(boards/accton-godwit): Add support for the accton-godwit_gfh7 flight controller documentations.

* docs(boards): align Accton Godwit GFH7 page with board template

Bring the new GFH7 page in line with the flight controller page
template and the board's own configuration, so readers can wire and
set up the board from it:

- Fix image paths (all images were broken) and resize/compress the
  images; split the tall wiring diagram into two.
- Use PX4 port labels and /dev/ttyS* devices in the serial port table
  instead of ArduPilot SERIALn numbering, matching default.px4board.
- State 8 PWM outputs (PWM9 only drives NeoPixel LEDs), with DShot,
  bidirectional DShot and timer groups.
- Explain how to enable CRSF/ELRS on the ELRS connector, since only
  S.BUS is started by default.
- Add the standard notes and missing sections (Power, CAN, OSD, SD
  card, debug port), the _default build target and QGC tip.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>

* add voltage description.

* modify doc description about UART、pinout.

* modified UART settings

* modified UART device description

* docs(boards/accton-godwit): tidy GFH7 voltage ratings section

Give the section its own heading and anchor, name the battery input after the VBAT pins, and drop the battery ratings that contradict each other (48V maximum vs 12S, and an undamaged range below the operating range) until the manufacturer confirms the values.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>

* docs(boards/accton-godwit): note GFH7 ships with PX4 bootloader

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>

* Modify these messages:
1.RCDGV pad group.
2.Voltage Ratings info.

* modified message:
1. UART port description
2. Telemetry Radios description

* docs(boards/accton-godwit): match GFH7 page to the new serial port labels

#28817 moves the PX4 RC port to the SBUS connector (UART5), labels the
ELRS connector (UART4) TELEM/SERIAL 4 and the receive-only ESC telemetry
UART (USART1) EXT2, and fixes the 12 V enable polarity. Update the radio,
serial port mapping, power and debug build notes to match.

Assisted-by: Kiro:claude-opus-5.5

* chore(boards/accton-godwit): drop GFH7 board files from the docs branch

The board port is reviewed and updated in #28817. The copies here had
already drifted from it (for example TEL3 on /dev/ttyS7, which does not
exist), so keep this pull request to the documentation only.

Assisted-by: Kiro:claude-opus-5.5

* docs(boards/accton-godwit): document the GFH7 ELRS default and IMU heater

#28817 makes CRSF/ELRS on the ELRS connector the default RC input, turns
S.BUS off by default, and adds the IMU heater (off by default). Update
the radio, serial port mapping and debug build notes to match, and add
an IMU Heater section that explains how to enable it.

Assisted-by: Kiro:claude-opus-5.5

* docs(boards/accton-godwit): add GFH7 block diagram

Review on #28830 asked for a block diagram of the main components
(sensors, power supply), as required by the board support guide.

Assisted-by: Kiro:claude-opus-5.5
Signed-off-by: g945643frankie <g945643@oz.nthu.edu.tw>

* docs(boards/accton-godwit): note GFH7 boots in Stabilized mode

The board sets COM_FLTMODE_BOOT to Stabilized instead of the PX4
default of Hold, so users should know which mode they get on power-up
and that a mode switch overrides it.

Assisted-by: Kiro:claude-opus-5.5
Signed-off-by: g945643frankie <g945643@oz.nthu.edu.tw>

* docs(boards/accton-godwit): fix GFH7 debug port tables

* docs(boards/accton-godwit): list GFH7 OSD debug pads in board order

* docs(accton-godwit_gfh7): reference QGC board recognition PR in tip

Point the Building Firmware tip at mavlink/qgroundcontrol#15212 so it is accurate until QGC recognises GFH7.

* docs(boards/accton-godwit): fix GFH7 review issues

The block diagram named the wrong secondary IMU, the firmware tip linked
a QGC PR that was closed unmerged, and the S.BUS pin on the D-VTX
connector (shown in the pinout) was undocumented. Also tidy the
telemetry and debug port sections to the style guide.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>

* docs(boards/accton-godwit): clarify GFH7 voltage ratings and label SBUS connector

Describe the 13V figure as the minimum for the 12V camera/VTX rail instead of a tested operating minimum, drop the unmeasured USB operational range, and relabel the UART5 connector in the block diagram as SBUS.

Signed-off-by: g945643frankie <g945643@oz.nthu.edu.tw>

* docs(boards): reorder Accton Godwit GFH7 page to match board template

Match the flight controller page template so the page reads like other
board pages, and keep the images in a folder named after the page.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>

* docs(boards): tidy Accton Godwit GFH7 page and add release note

Address the remaining editorial review findings so the page matches the
board template and other board pages, and list the new board in the
release notes.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>

* docs(boards): rename to G-FH7 and address review questions

Rename the reader-facing board name from GFH7 to G-FH7 in the board
page, sidebar, manufacturer list, and main release notes.

State the battery input as up to 12S LiPo, note that the IMU heater
current is calculated from the resistor value (not measured), correct
the UART5 wiring for the SBUS and A-VTX connectors, and link the
IST8310 datasheet.

Signed-off-by: g945643frankie <g945643@oz.nthu.edu.tw>

* docs(boards): update G-FH7 pin definition image

Replace the pinout with the updated drawing that labels UART5_TX on the
A-VTX connector and UART5_TX/UART5_RX on the SBUS connector.

Signed-off-by: g945643frankie <g945643@oz.nthu.edu.tw>

* docs(boards): tidy G-FH7 UART5 wording and block diagram battery label

Put the S.BUS setup line first in the SBUS receiver bullet, so "To use
it" refers to the receiver rather than the A-VTX TX pin, and shorten the
UART5 serial table cell and the duplicated heater current note.

Change the block diagram battery label from "4~12S" to "Up to 12S",
since the authors confirmed there is no verified lower limit and the
page now says "Up to 12S LiPo".

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>

* docs(boards): document G-FH7 A-VTX control and VTX driver

The A-VTX TX pin is the SmartAudio/Tramp control line, shared with
UART5_TX on the SBUS connector. Document how to use it (VTX_SER_CFG set
to Radio Controller) and that it can't be used together with an S.BUS
receiver on the SBUS connector.

Signed-off-by: g945643frankie <g945643@oz.nthu.edu.tw>

* docs(boards): fix G-FH7 RC, buzzer and wording review issues

Tell readers to disable CRSF when enabling DSM or GHST, since CRSF is
on TELEM/SERIAL 4 by default, and note that DSM receivers can't be bound
from PX4 because the board defines no SPEKTRUM_POWER. Say the BZ output
needs an active buzzer, because the board drives it as a plain GPIO.

Also define DFU, PPS and VTX at first use, link parameter setting, use
"co-processor" for the OSD consistently, fix ambiguous references in
the OSD and debug pad text, and narrow the debug-build ELRS limit to
the ELRS connector.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>

* docs: G-FH7: remove VTX control, apply ADC/power monitoring suggestions

PX4's VTX driver swaps RX/TX on the RC port (no RC_SERIAL_SWAP_RXTX on
this board), so SmartAudio/Tramp would not come out on the A-VTX TX pin.
State that PX4 does not use that pin instead.

Signed-off-by: g945643frankie <g945643@oz.nthu.edu.tw>

* Update docs/en/flight_controller/accton-godwit_gfh7.md

* Update docs/en/flight_controller/accton-godwit_gfh7.md

* Update docs/en/releases/main.md

* docs(accton-godwit_gfh7): address review feedback

Apply remaining Hamish review suggestions on the G-FH7 board page:
clarify the switchable 12 V BEC output, note serial flashing over TELEM only,
expand GHST as TBS Ghost, warn that 3.3 V DSM receivers need a separate supply,
and match the OSD SWD pad wording to the FMU debug table.

* docs(boards): tidy G-FH7 interface, power, BOOT and ESC wiring text

Move the Interface Summary under Pinouts to match the board page
template, note that current monitoring needs setup, name the board's
BOOT button, and describe the ESC wiring diagram as it is drawn
(4-in-1 ESC on the ESC connector only).

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>

* docs(boards): flatten G-FH7 images onto white for dark mode

The board drawings were black line art on a transparent background, so
in dark mode the lines all but vanished against the dark page.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>

* docs(boards): drop space between value and unit on G-FH7 page

PX4 prefers no space between a value and its unit symbol (3V, not 3 V).

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>

---------

Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
Signed-off-by: g945643frankie <g945643@oz.nthu.edu.tw>
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Co-authored-by: g945643frankie <g945643@oz.nthu.edu.tw>
Co-authored-by: g945643frankie <106499958+g945643frankie@users.noreply.github.com>
2026-11-18 18:34:48 +11:00
45ad2dbfd2 feat(boards/accton-godwit): Add support for the accton-godwit_gfh7 flight controller (#28817)
Assisted-by: Kiro:claude-opus-5.5
Signed-off-by: g945643frankie <g945643@oz.nthu.edu.tw>
Co-authored-by: g945643frankie <g945643@oz.nthu.edu.tw>
Co-authored-by: Julian Oes <julian@oes.ch>
2026-11-18 18:30:13 +11:00
Jonas Perolini 3a2477c00a refactor(navigator): split Return destination selection per RTL_TYPE (#29682)
Assisted-by: Claude:claude-opus-5-5
2026-11-18 06:21:06 +01:00
Jonas Perolini f76d30eb66 test(navigator): characterise the Return destination per RTL_TYPE (#29681)
Assisted-by: Claude:claude-opus-5-5
2026-11-18 05:36:44 +01:00
Ban Siesta (Bot) 632df68651 fix(mavlink): take lock_send for TIMESYNC replies and event re-sends (#29856)
The receiver thread answers TIMESYNC requests and REQUEST_EVENT
directly from handle_message(). Both sends went through
_mav_finalize_message_chan_send() without lock_send(), so they raced
with Mavlink::task_main on the shared per-channel mavlink_status_t
(current_tx_seq). TSan caught this in the SITL hex tests:

  Read  current_tx_seq  task_main  HIGHRES_IMU stream (holds lock_send)
  Write current_tx_seq  mavlink_rcv  MavlinkTimesync::handle_message

The other receiver-side senders (mission, params, ftp, commands) already
take lock_send(); these two were missed.

Assisted-by: Claude:claude-opus-5-5
2026-11-18 14:04:08 +13:00
Julian Oes f2c3ab45d1 fix(mavlink): close log files in the receiver thread (#29854)
The log handler opens the log file in the receiver thread, but on
'mavlink stop' its destructor runs in the stop task and fclose()s it
there. On NuttX a FILE belongs to the task group that opened it:
fclose() from another task frees it while it stays linked in the
owner's stream list, and the owner frees it again on exit. This double
free corrupts the heap when USB is unplugged during a log download
(hardfault in mm_free, or load_mon hanging in mallinfo()).

Close the files at the end of MavlinkReceiver::run(), in the owning
thread.

Ported from the v1.18 fix in #29187.

Signed-off-by: Julian Oes <julian@oes.ch>
2026-11-18 13:10:08 +13:00
Johnny Kao 483f73d19d fix(mavlink): ignore foreign mission counts for upload timeout (#29537)
Only the active upload partner may refresh the protocol receive timeout.

Assisted-by: ChatGPT:gpt-6
2026-11-18 12:33:36 +13:00
mumumu cca69f2a5d fix(mag_bias_estimator): return after cleanup in the stop path (#29792)
Run() calls exit_and_cleanup(desc) when should_exit() is set. That deletes the object, but Run() then continues to use _vehicle_status_sub, so the stop path reads freed memory.

Add the missing return. Reproduced with an ASan SITL build:

  ERROR: AddressSanitizer: heap-use-after-free ... READ of size 8
    #0 uORB::Subscription::subscribe()  platforms/common/uORB/Subscription.cpp:48
    #1 uORB::Subscription::updated()    platforms/common/uORB/Subscription.hpp:133
    #2 mag_bias_estimator::MagBiasEstimator::Run()  MagBiasEstimator.cpp:84

  freed by: MagBiasEstimator::~MagBiasEstimator()

Trigger: 'mag_bias_estimator start', then 'mag_bias_estimator stop'.

Assisted-by: deepseek

Signed-off-by: Summermu <23356722+Summermu@users.noreply.github.com>
2026-11-17 14:01:59 -07:00
PX4BuildBot dc0cf5ec2e docs: auto-sync metadata [skip ci]
Co-Authored-By: PX4 BuildBot <bot@px4.io>
2026-11-17 17:43:09 +00:00
Balduin da7f6cccd4 fix(parameters): add missing units to parameter metadata (#29819)
* docs(parameters): add 4 new units

 - A/V (ampere per volt)
 - Pa (pascal)
 - Pa/V (pascal per volt)
 - MHz (megahertz)

* docs(parameters): add missing units

These parameters have a physical unit (often stated in their own
description) but no unit field, so QGC and the parameter reference show
them as unitless.

Add the missing units to 116 parameters.

Assisted-by: Claude:claude-opus-5-5

* docs(parameters): drop units from descriptions now in the unit field

Assisted-by: Claude:claude-opus-5-5

* fix(microstrain): label orientation parameters deg

src/drivers/ins/microstrain/MicroStrain.cpp requires these to be in
degrees (they are converted to radians at line 1121-1124), but the param
docstring mentioned which was moved to the unit field just before.

Fix by labelling correctly as degrees.

Signed-off-by: Balduin <balduin@auterion.com>

* docs(parameters): fix smaller inconsistencies

Address review from @dakejahl:
 - mc_nn_control: MC_NN_MIN_RPM also in units of rpm
 - sensors: remove redundant '#unit: Pa' comment
 - microstrain: Typo in MS_GNSS_OFF2_Z

Signed-off-by: Balduin <balduin@auterion.com>

---------

Signed-off-by: Balduin <balduin@auterion.com>
2026-11-17 10:36:24 -07:00