mirror of
https://github.com/PX4/PX4-Autopilot.git
synced 2026-07-24 15:27:41 +08:00
* refactor(uORB): out-line PublicationBase/Subscription methods to save flash Move the type-independent PublicationBase::advertise()/publish() and Subscription::copy()/update() bodies out of the headers into Publication.cpp / Subscription.cpp, leaving only declarations inline. PX4 links with bfd ld (no identical-code folding) and without LTO, so these header-inline methods were emitted per translation unit: GCC both .isra-cloned them (~39 publish, 25 advertise, 17 copy, 12 update copies) and fully inlined them into many callers. Out-lining collapses all of that to a single shared definition each. This is the out-of-line follow-up to #27526, which hoisted advertise/ publish from the Publication<T> template into the non-template PublicationBase but kept them inline in the header. The methods were already emitted as separate clones, so callers already pay a bl and the publish/read hot paths are unchanged -- this is pure code motion. Saves 10.4 KB .text on auterion_fmu-v6x (1,949,568 -> 1,939,168). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(uORB): out-line SubscriptionCallback register/unregister to save flash Move SubscriptionCallback::registerCallback()/unregisterCallback() out of the header into a new SubscriptionCallback.cpp. Like the Publication/Subscription methods, these were emitted per translation unit (PX4 links with bfd ld, no ICF, no LTO): GCC .isra-cloned them and inlined them into every WorkItem-based subscriber's setup path. registerCallback() runs only at subscription/callback setup (cold path), so out-lining is pure code motion with no hot-path change. Saves 4.9 KB .text on auterion_fmu-v6x (1,939,168 -> 1,934,128). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(uORB): out-line remaining Subscription methods to save flash Extends this PR's pattern to the rest of Subscription: move the type-independent methods still defined in the header (constructors, destructor, copy/move assignment, updated(), advertised()) into Subscription.cpp so they are emitted once instead of inlined into every translation unit. updated()/advertised() inline the Manager::updates_available / is_advertised (DeviceNode) chain, and the constructors were inlined at every subscription site, so most of the remaining duplication lived there. ~9.4 KB .text saved on ark_fmu-v6x_default. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Jacob Dahl <dahl.jakejacob@gmail.com>
162 lines
4.5 KiB
C++
162 lines
4.5 KiB
C++
/****************************************************************************
|
|
*
|
|
* Copyright (c) 2019 PX4 Development Team. All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* 3. Neither the name PX4 nor the names of its contributors may be
|
|
* used to endorse or promote products derived from this software
|
|
* without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
|
|
* FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
|
|
* COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
|
|
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
|
|
* OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
|
|
* AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
|
|
* ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
*
|
|
****************************************************************************/
|
|
|
|
/**
|
|
* @file SubscriptionCallback.hpp
|
|
*
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <uORB/SubscriptionInterval.hpp>
|
|
#include <containers/List.hpp>
|
|
#include <px4_platform_common/px4_work_queue/WorkItem.hpp>
|
|
|
|
namespace uORB
|
|
{
|
|
|
|
// Subscription wrapper class with callbacks on new publications
|
|
class SubscriptionCallback : public SubscriptionInterval, public ListNode<SubscriptionCallback *>
|
|
{
|
|
public:
|
|
/**
|
|
* Constructor
|
|
*
|
|
* @param meta The uORB metadata (usually from the ORB_ID() macro) for the topic.
|
|
* @param interval_us The requested maximum update interval in microseconds.
|
|
* @param instance The instance for multi sub.
|
|
*/
|
|
SubscriptionCallback(const orb_metadata *meta, uint32_t interval_us = 0, uint8_t instance = 0) :
|
|
SubscriptionInterval(meta, interval_us, instance)
|
|
{
|
|
}
|
|
|
|
virtual ~SubscriptionCallback()
|
|
{
|
|
unregisterCallback();
|
|
};
|
|
|
|
bool registerCallback();
|
|
|
|
void unregisterCallback();
|
|
|
|
/**
|
|
* Change subscription instance
|
|
* @param instance The new multi-Subscription instance
|
|
*/
|
|
bool ChangeInstance(uint8_t instance)
|
|
{
|
|
bool ret = false;
|
|
|
|
if (instance != get_instance()) {
|
|
const bool registered = _registered;
|
|
|
|
if (registered) {
|
|
unregisterCallback();
|
|
}
|
|
|
|
if (_subscription.ChangeInstance(instance)) {
|
|
ret = true;
|
|
}
|
|
|
|
if (registered) {
|
|
registerCallback();
|
|
}
|
|
|
|
} else {
|
|
// already on desired index
|
|
return true;
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
virtual void call() = 0;
|
|
|
|
bool registered() const { return _registered; }
|
|
|
|
protected:
|
|
|
|
bool _registered{false};
|
|
|
|
};
|
|
|
|
// Subscription with callback that schedules a WorkItem
|
|
class SubscriptionCallbackWorkItem : public SubscriptionCallback
|
|
{
|
|
public:
|
|
/**
|
|
* Constructor
|
|
*
|
|
* @param work_item The WorkItem that will be scheduled immediately on new publications.
|
|
* @param meta The uORB metadata (usually from the ORB_ID() macro) for the topic.
|
|
* @param instance The instance for multi sub.
|
|
*/
|
|
SubscriptionCallbackWorkItem(px4::WorkItem *work_item, const orb_metadata *meta, uint8_t instance = 0) :
|
|
SubscriptionCallback(meta, 0, instance), // interval 0
|
|
_work_item(work_item)
|
|
{
|
|
}
|
|
|
|
virtual ~SubscriptionCallbackWorkItem() = default;
|
|
|
|
void call() override
|
|
{
|
|
// schedule immediately if updated (queue depth or subscription interval)
|
|
if ((_required_updates == 0)
|
|
|| (Manager::updates_available(_subscription.get_node(), _subscription.get_last_generation()) >= _required_updates)) {
|
|
if (updated()) {
|
|
_work_item->ScheduleNow();
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Optionally limit callback until more samples are available.
|
|
*
|
|
* @param required_updates Number of queued updates required before a callback can be called.
|
|
*/
|
|
void set_required_updates(uint8_t required_updates)
|
|
{
|
|
// TODO: constrain to queue depth?
|
|
_required_updates = required_updates;
|
|
}
|
|
|
|
private:
|
|
px4::WorkItem *_work_item;
|
|
|
|
uint8_t _required_updates{0};
|
|
};
|
|
|
|
} // namespace uORB
|