mirror of
https://github.com/PX4/PX4-Autopilot.git
synced 2026-07-24 15:27:41 +08:00
21dc34fc5b
* refactor(uORB): out-line PublicationBase/Subscription methods to save flash Move the type-independent PublicationBase::advertise()/publish() and Subscription::copy()/update() bodies out of the headers into Publication.cpp / Subscription.cpp, leaving only declarations inline. PX4 links with bfd ld (no identical-code folding) and without LTO, so these header-inline methods were emitted per translation unit: GCC both .isra-cloned them (~39 publish, 25 advertise, 17 copy, 12 update copies) and fully inlined them into many callers. Out-lining collapses all of that to a single shared definition each. This is the out-of-line follow-up to #27526, which hoisted advertise/ publish from the Publication<T> template into the non-template PublicationBase but kept them inline in the header. The methods were already emitted as separate clones, so callers already pay a bl and the publish/read hot paths are unchanged -- this is pure code motion. Saves 10.4 KB .text on auterion_fmu-v6x (1,949,568 -> 1,939,168). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(uORB): out-line SubscriptionCallback register/unregister to save flash Move SubscriptionCallback::registerCallback()/unregisterCallback() out of the header into a new SubscriptionCallback.cpp. Like the Publication/Subscription methods, these were emitted per translation unit (PX4 links with bfd ld, no ICF, no LTO): GCC .isra-cloned them and inlined them into every WorkItem-based subscriber's setup path. registerCallback() runs only at subscription/callback setup (cold path), so out-lining is pure code motion with no hot-path change. Saves 4.9 KB .text on auterion_fmu-v6x (1,939,168 -> 1,934,128). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(uORB): out-line remaining Subscription methods to save flash Extends this PR's pattern to the rest of Subscription: move the type-independent methods still defined in the header (constructors, destructor, copy/move assignment, updated(), advertised()) into Subscription.cpp so they are emitted once instead of inlined into every translation unit. updated()/advertised() inline the Manager::updates_available / is_advertised (DeviceNode) chain, and the constructors were inlined at every subscription site, so most of the remaining duplication lived there. ~9.4 KB .text saved on ark_fmu-v6x_default. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Jacob Dahl <dahl.jakejacob@gmail.com>