mirror of
https://github.com/PX4/PX4-Autopilot.git
synced 2026-07-24 15:27:41 +08:00
* refactor(uORB): out-line PublicationBase/Subscription methods to save flash Move the type-independent PublicationBase::advertise()/publish() and Subscription::copy()/update() bodies out of the headers into Publication.cpp / Subscription.cpp, leaving only declarations inline. PX4 links with bfd ld (no identical-code folding) and without LTO, so these header-inline methods were emitted per translation unit: GCC both .isra-cloned them (~39 publish, 25 advertise, 17 copy, 12 update copies) and fully inlined them into many callers. Out-lining collapses all of that to a single shared definition each. This is the out-of-line follow-up to #27526, which hoisted advertise/ publish from the Publication<T> template into the non-template PublicationBase but kept them inline in the header. The methods were already emitted as separate clones, so callers already pay a bl and the publish/read hot paths are unchanged -- this is pure code motion. Saves 10.4 KB .text on auterion_fmu-v6x (1,949,568 -> 1,939,168). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(uORB): out-line SubscriptionCallback register/unregister to save flash Move SubscriptionCallback::registerCallback()/unregisterCallback() out of the header into a new SubscriptionCallback.cpp. Like the Publication/Subscription methods, these were emitted per translation unit (PX4 links with bfd ld, no ICF, no LTO): GCC .isra-cloned them and inlined them into every WorkItem-based subscriber's setup path. registerCallback() runs only at subscription/callback setup (cold path), so out-lining is pure code motion with no hot-path change. Saves 4.9 KB .text on auterion_fmu-v6x (1,939,168 -> 1,934,128). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(uORB): out-line remaining Subscription methods to save flash Extends this PR's pattern to the rest of Subscription: move the type-independent methods still defined in the header (constructors, destructor, copy/move assignment, updated(), advertised()) into Subscription.cpp so they are emitted once instead of inlined into every translation unit. updated()/advertised() inline the Manager::updates_available / is_advertised (DeviceNode) chain, and the constructors were inlined at every subscription site, so most of the remaining duplication lived there. ~9.4 KB .text saved on ark_fmu-v6x_default. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Jacob Dahl <dahl.jakejacob@gmail.com>
176 lines
4.3 KiB
C++
176 lines
4.3 KiB
C++
/****************************************************************************
|
|
*
|
|
* Copyright (c) 2012-2019 PX4 Development Team. All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* 3. Neither the name PX4 nor the names of its contributors may be
|
|
* used to endorse or promote products derived from this software
|
|
* without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
|
|
* FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
|
|
* COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
|
|
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
|
|
* OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
|
|
* AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
|
|
* ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
*
|
|
****************************************************************************/
|
|
|
|
/**
|
|
* @file Subscription.cpp
|
|
*
|
|
*/
|
|
|
|
#include "Subscription.hpp"
|
|
#include <px4_platform_common/defines.h>
|
|
|
|
namespace uORB
|
|
{
|
|
|
|
bool Subscription::subscribe()
|
|
{
|
|
// check if already subscribed
|
|
if (_node != nullptr) {
|
|
return true;
|
|
}
|
|
|
|
if (_orb_id != ORB_ID::INVALID && uORB::Manager::get_instance()) {
|
|
unsigned initial_generation;
|
|
void *node = uORB::Manager::orb_add_internal_subscriber(_orb_id, _instance, &initial_generation);
|
|
|
|
if (node) {
|
|
_node = node;
|
|
_last_generation = initial_generation;
|
|
return true;
|
|
}
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
void Subscription::unsubscribe()
|
|
{
|
|
if (_node != nullptr) {
|
|
uORB::Manager::orb_remove_internal_subscriber(_node);
|
|
}
|
|
|
|
_node = nullptr;
|
|
_last_generation = 0;
|
|
}
|
|
|
|
bool Subscription::update(void *dst)
|
|
{
|
|
if (subscribe()) {
|
|
return Manager::orb_data_copy(_node, dst, _last_generation, true);
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool Subscription::copy(void *dst)
|
|
{
|
|
if (subscribe()) {
|
|
return Manager::orb_data_copy(_node, dst, _last_generation, false);
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool Subscription::ChangeInstance(uint8_t instance)
|
|
{
|
|
if (instance != _instance) {
|
|
if (uORB::Manager::orb_device_node_exists(_orb_id, instance)) {
|
|
// if desired new instance exists, unsubscribe from current
|
|
unsubscribe();
|
|
_instance = instance;
|
|
subscribe();
|
|
return true;
|
|
}
|
|
|
|
} else {
|
|
// already on desired index
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
Subscription::Subscription(ORB_ID id, uint8_t instance) :
|
|
_orb_id(id),
|
|
_instance(instance)
|
|
{
|
|
subscribe();
|
|
}
|
|
|
|
Subscription::Subscription(const orb_metadata *meta, uint8_t instance) :
|
|
_orb_id((meta == nullptr) ? ORB_ID::INVALID : static_cast<ORB_ID>(meta->o_id)),
|
|
_instance(instance)
|
|
{
|
|
subscribe();
|
|
}
|
|
|
|
Subscription::Subscription(const Subscription &other) : _orb_id(other._orb_id), _instance(other._instance) {}
|
|
|
|
Subscription::Subscription(const Subscription &&other) noexcept : _orb_id(other._orb_id), _instance(other._instance) {}
|
|
|
|
Subscription &Subscription::operator=(const Subscription &other)
|
|
{
|
|
// Check for self-assignment
|
|
if (this == &other) {
|
|
return *this;
|
|
}
|
|
|
|
unsubscribe();
|
|
_orb_id = other._orb_id;
|
|
_instance = other._instance;
|
|
return *this;
|
|
}
|
|
|
|
Subscription &Subscription::operator=(Subscription &&other) noexcept
|
|
{
|
|
unsubscribe();
|
|
_orb_id = other._orb_id;
|
|
_instance = other._instance;
|
|
return *this;
|
|
}
|
|
|
|
Subscription::~Subscription()
|
|
{
|
|
unsubscribe();
|
|
}
|
|
|
|
bool Subscription::advertised()
|
|
{
|
|
if (subscribe()) {
|
|
return Manager::is_advertised(_node);
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool Subscription::updated()
|
|
{
|
|
if (subscribe()) {
|
|
return Manager::updates_available(_node, _last_generation);
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
} // namespace uORB
|