* docs(msg): clarify RoverPositionSetpoint field descriptions
* feat(rover): introduce a course parameter to get rid of the course-hold workaround hack (#29245)
* fix(ros2): update ros2 interface lib pin to include course and target_ned in RoverPositionSetpoint
* style(msg): use single space before comments in RoverPositionSetpoint
The column padding triggers the msg doc generator's multiple-whitespace
note on every field.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
* fix(msg): update RoverPositionSetpoint descriptions
* feat(msg): add SurfaceVehicleCourseSetpoint
* fix(repositories): update px4 ros2 interface lib version
* fix(msg): add comment that yaw in RoverPositionSetpoint msg is currently not used
* fix(msg): rename surface_vehicle_course_setpoint to planar_course_setpoint
* fix(rover): keep the course line while a course setpoint is streamed
A PlanarCourseSetpoint without start_ned re-anchored the line at the
vehicle position on every message. Publishers that stream the setpoint,
the usual pattern over ROS 2, therefore never got cross-track error
corrected: in SITL the rover drifted 3.8 m off course over 54 m. Keep the
current line while the same course is published without a start
position, and only re-anchor when the course changes.
Also document that a NaN course leaves the position controller idle and
that yaw is currently unused, matching RoverPositionSetpoint.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Michael Fritsche <frimi999@gmail.com>
* fix(msg): rename planar_course_setpoint to ugv_usv_course_setpoint
* docs(msg): add documentation for UgvUsvCourseSetpoint
* feat(rover): proper guided course implementation
* fix(rover): rename course setpoint cruising_speed param to speed
* fix(msgs): rename ugv_usv_course_setpoint.msg to surface_vehicle_course_setpoint.msg
* docs(rover): clarify course setpoint wording
Doc review fixes for the course hold docs and message comments:
unclear antecedents, a misplaced modifier, a missing verb, and the
pure pursuit sentence separated from the course setpoint text it no
longer described. The yaw @invalid tag now matches in both messages,
since no controller reads the field.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
* Apply suggestion from @hamishwillee
* docs(rover): fix course tracking formulation for the different rover types
* fix(rover): maintain current speed upon guided course mode entry
* docs(rover): clarify guided course mode documentation.
* fix(rover): handle nav_state_land in rovers
* fix(rovers): polish the used terminology
* docs(rover): switch to list for guided course mode usable commands
---------
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
Signed-off-by: Michael Fritsche <frimi999@gmail.com>
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
* RoverAttitudeSetpoint - whitespace
* Format RoverAttitudeStatus.msg for consistency
* Format RoverPositionSetpoint.msg for consistency
* Format msg/RoverRateSetpoint.msg for consistency
* Format msg/RoverRateStatus.msg for consistency
* Format msg/RoverSpeedSetpoint.msg for consistency
* Reformat RoverSpeedStatus.msg for consistency
* Fix formatting of pid_yaw_rate_integral field
* Fix formatting in RoverSteeringSetpoint.msg
* Fix formatting in RoverThrottleSetpoint.msg
* Apply suggestions from code review