* feat(tools): add a script to convert v1.17 parameter files for v1.18
param_translation.cpp converts renamed parameters only when PX4 upgrades
the parameters stored on the vehicle. QGroundControl loads a .params
file parameter by parameter, so values saved under old names are
ignored, and RC*_REV saved as -1.000000 load as 0 into the now integer
parameters. The script applies the same conversions to the file.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: A.Burak Tektas <15087318+Abtektas@users.noreply.github.com>
* fix(tools): keep the v1.18 heater sensor default in converted files
A v1.17 vehicle does not store SENS_TEMP_ID at its default of 0, so the
upgrade never converts it and HEATER1_SENS_ID keeps its v1.18 default,
the board's sensor or auto-select. The script wrote -1 instead, which
disables the heater on boards that v1.18 heats by default.
Also list EKF2_REQ_PDOP, which v1.18 raises to 4 on fixed-wing, log
integer values without an exponent, end a copied line that has no
newline before the parameters follow it, and say what the translation
test catches.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: A.Burak Tektas <15087318+Abtektas@users.noreply.github.com>
* docs(releases): link the v1.17 parameter file script in 1.18 notes
Item 13 tells users to check a parameter file saved on v1.17 by hand.
Point them to Tools/migrate_param_file.py, which converts such a file.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: A.Burak Tektas <15087318+Abtektas@users.noreply.github.com>
* fix(tools): convert the v1.17 auxiliary global position parameters
param_translation.cpp moves EKF2_AGP_CTRL, _MODE, _DELAY, _NOISE and
_GATE to the first source set, EKF2_AGP0_*, and sets EKF2_AGP0_ID to 1
when EKF2_AGP_CTRL is set. The script listed them as removed, so a
converted file came out with aux global position fusion disabled.
Convert them the same way. QGroundControl lists EKF2_AGP0_* only once
EKF2_AGP0_ID is set and the vehicle reboots, so the script and item 13
of the 1.18 notes say to load the file again after a reboot.
EKF2_AGP_NOISE at 0.9 is listed as a v1.17 default (1.0 in v1.18).
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: A.Burak Tektas <15087318+Abtektas@users.noreply.github.com>
* fix(tools): replace the v1.17 RoboClaw output defaults
The RoboClaw outputs moved from 0 to 256 with stop at 128 to 0 to 254
with stop at 127. A saved file holds the v1.17 defaults, and the script
kept them: RBCLW_DIS 128 drives the motors forward at speed 1 while
disarmed, and RBCLW_MAX 256 is above the v1.18 maximum of 254.
At their v1.17 defaults RBCLW_DIS, _MIN and _MAX now get the v1.18
default, as after an upgrade of the parameters stored on the vehicle,
since the firmware does not store defaults. Other RBCLW_DIS, _MIN, _MAX
and _FAIL values are kept and listed for a check.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: A.Burak Tektas <15087318+Abtektas@users.noreply.github.com>
* fix(tools): drop the reload after a reboot for EKF2_AGP0_*
QGroundControl sends the rows of a .params file that the vehicle does not
list as new parameters, since the file holds their types, and PX4
accepts PARAM_SET for any parameter in its table. So EKF2_AGP0_* are set
on the first load, and the note to load the file again after a reboot
is wrong. Only a Mission Planner file, which has no types, cannot send
them.
Remove the note from the script and from item 13 of the 1.18 notes.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: A.Burak Tektas <15087318+Abtektas@users.noreply.github.com>
* fix(tools): list the X25-EVO core heater and other components
- CORE_IMU_TEMP, _FF, _I, _P and CORE_TEMP_ID of the CUAV X25-EVO core
heater are gone in v1.18 without a translation, the board now uses
HEATER2_*. They passed through unlisted; list them as removed with
the HEATER2_* parameter to set.
- rc.boat_defaults still sets NAV_ACC_RAD 2, so the note that v1.18 uses
10 applies to multicopters only.
- A vehicle with MAV_COMP_ID other than 1 saves its parameters under
that component, so the script converted nothing and said nothing.
Warn when the file has no parameters of component 1.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: A.Burak Tektas <15087318+Abtektas@users.noreply.github.com>
* fix(tools): list board defaults changed on Skynode and i.MX RT
A saved v1.17 file holds the v1.17 board defaults, and v1.18 changed
some of them:
- On Skynode the fmu-v5x defaults set EKF2_MULTI_IMU 0 and
SENS_IMU_MODE 1, since it is too loaded for the three EKF instances of
the STM32F7 defaults (3 and 0).
- The i.MX RT defaults match fmu-v6x: EKF2_MULTI_IMU 3, SENS_IMU_MODE 0,
IMU_GYRO_FFT_EN 1 and UAVCAN_ENABLE 2, where v1.17 used 0, 1, 0 and 0.
List these values as v1.17 defaults with the boards they apply to. One
parameter can change differently on each set of boards.
Airframes 4016, 4020 and 24001 still set NAV_ACC_RAD 2 in v1.18, so name
them in the multicopter note.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: A.Burak Tektas <15087318+Abtektas@users.noreply.github.com>
---------
Signed-off-by: A.Burak Tektas <15087318+Abtektas@users.noreply.github.com>
Only the imx-image-ros image ships mavlink-router, and its main.conf
exposes a UDP server on port 10000 instead of pushing to a ground
station, on purpose, so Wi-Fi is not flooded with broadcast traffic.
Say so, tell the reader to add the board as a UDP server in
QGroundControl or to add a Normal endpoint for a fixed ground station,
and point at the router's own endpoint documentation.
/dev/ttyros existed but no PX4 module could use it: it was not a board
serial port, so UXRCE_DDS_CFG could not select it and nothing started the
client. Registering it as TELEM 2 lets the generated rc.serial start
uxrce_dds_client on it from the parameter, like a companion link on any
other board, with nothing enabled by default. Tested on the board: with
UXRCE_DDS_CFG set to 102 the client starts at boot on /dev/ttyros at
921600 baud and its session frames arrive on the Linux side. The page
gets a ROS 2 section with the three steps, and the agent install points
at the uXRCE-DDS page since the Linux images do not ship it.
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Explain the networking expansion lane and the three boards it serves,
add the MCUboot flash layout with both slots so slot0 is defined where
it is first used, say that J2 CONSOLE does not follow DS-009 and that
output 8 only works as PWM with S1 open, note the NSH console option
in Debug Port, and move Power and Voltage Ratings to the template
position after Pinouts.
Co-authored-by: Andre Heinemans <andre.heinemans@nxp.com>
Bring the page closer to the board page template and fix issues found in
review: group the connection sections under Assembly, move the images to a
folder named after the page, link the sensor parts, state that DSM bind is
unsupported (no SPEKTRUM_POWER), note the onboard BMM350 and external
compass detection, use the standard servo-rail wording, and say OneShot is
unsupported on every output (TPM4-6 run at 1 MHz, below BOARD_ONESHOT_FREQ).
Also fix grammar and tool-name styling, and list the board under New Flight
Controllers in the release note.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
Co-authored-by: Andre Heinemans <andre.heinemans@nxp.com>
Document the board the way the other manufacturer supported autopilots
are: what runs where on the i.MX 95, the sensors and ports, the RPMsg
links to Linux, the two build images and key signing for MCUboot, and
flashing over SWD with pyOCD. Hardware details and the Linux image link
to the NXP-Robotics repositories instead of being repeated.
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Co-authored-by: Andre Heinemans <andre.heinemans@nxp.com>
PX4 runs every frame type in the Airframe Reference on any flight
controller with enough outputs, so these sections said nothing specific
to the board. The board page template no longer includes them.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
The 2.3 degree FoV published for the TFMINI/TFMINI-S dates back to
#24700 without a documented source and does not match the Benewake
datasheet, which specifies 2 degrees. Publish the datasheet value so
collision prevention and MAVLink consumers see an honest envelope.
Add the TFMINI Plus as variant 4. It speaks the same protocol but has
a 3.6 degree FoV and 0.1 m minimum range per the datasheet. Selecting
the TFMINI variant for a Plus made PX4 discard all readings below
0.4 m (signal_quality forced to 0), starving EKF2 of range aiding in
close-range use.
Update the PX4 docs so the model table, reported ranges and
out-of-range behaviour distinguish the two models.
Bench-verified on px4_fmu-v6x with a TFMINI Plus: variant 1 reports
h_fov 0.0349 rad and stamps quality 0 below 0.4 m; variant 4 reports
h_fov 0.0628 rad, keeps quality -1 from 0.11 to 0.30 m and stamps
quality 0 at 0.05 m.
Fixes#29460
Assisted-by: GLM:glm-5.3-flash
Signed-off-by: jiakun <53556221+ddwolf87@users.noreply.github.com>
* docs(releases): add two notes lines, move the IMU voter line to 1.18
Follow Me (#29029) and the fixed-wing course to heading fix (#29567)
merged without a release notes entry. The IMU voter line (#28811) was
backported to release/1.18 in #29457, so it belongs in 1.18.md rather
than main.md.
Signed-off-by: Saibernard Yogendran <bernie97@seas.upenn.edu>
* docs(releases): link and tighten the Follow Me and course control notes
Link the EKF2 instance and true airspeed terms, say the Follow Me fix
applies while the mode is active (#29029), and give the airspeed the 7°
heading error was worked out at (#29567).
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
---------
Signed-off-by: Saibernard Yogendran <bernie97@seas.upenn.edu>
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
* docs(boards): restructure Pixhawk 4 page to the board page template
Move the existing content into the flight-controller page template's
sections, headings and anchors, with no change to what the page says,
so that the content additions that follow can be reviewed on their own.
The Quick Summary list becomes Specifications sub-sections, the
connector image moves into Pinouts and the dimensions image into
Mechanical Data, Voltage Ratings moves before Serial Port Mapping,
and Further info becomes Further Information. Port labels are in code
style, and units follow the docs style guide. Links to the changed
anchors are updated.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
* docs(boards): add Pixhawk 4 PWM outputs, power and setup sections
Fill in the sections the board page template expects, from the board
source (boards/px4/fmu-v5) and Holybro's datasheet, pinouts and
product page.
- Mark the board discontinued by Holybro but still supported by PX4,
with matching SUMMARY, sidebar and category entries
- Specifications: current IO processor, sensor buses, USB, parameter
storage, SD card, max input voltage and current sensing, and the
datasheet weight
- PWM Outputs: IO and FMU outputs, no DShot, timer groups, and the
capture inputs on CAP & ADC IN
- Power, SD Card, Radio Control, GPS & Compass, Telemetry and CAN
- Serial Port Mapping: USART1, flow control column, printed port
labels, and the same table on the serial port mapping page
- Debug Port: Pixhawk Debug Mini, and the console UART
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
* docs(boards): fix Pixhawk 4 specs, links and wording from review
Take the weight and operating temperature from Holybro's latest
datasheet, and link that datasheet in place of the older in-repo copy,
which contradicted the page.
Give the serial and I2C interface lines in the board page template's
form, where the board source and Holybro's pinout agree, and add the
template content the page was missing: the servo rail note, capture
pins as outputs, DSM/S.BUS receiver power pins, the internal compass,
and how to enable a second GPS (GPS_2_CONFIG has no default).
Also fix the wiring quick start's link text for the renamed Pinouts
heading, and make S.BUS spelling and port labels consistent.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
* docs(boards): apply Holybro corrections and discontinued markers to Pixhawk 4
Holybro confirmed the board is discontinued and corrected the weight,
operating temperature, input voltage limits, RC port routing and DShot
support. The discontinued markers follow the earlier discontinued board
pages, and the Pixhawk Standard list now separates discontinued boards.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
---------
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
* fix(failure_detector): check altitude loss without a height setpoint
The altitude loss check only ran when an altitude setpoint was present.
While the pilot moves the throttle stick in Altitude/Position mode the
setpoint is NaN, so a failure during a manual climb or manual descent
was never detected.
When there is no height setpoint but a vertical velocity setpoint is
available, keep a reference that remembers the highest altitude reached
and only moves down at the commanded descent rate. Climb or hold
commands therefore protect the best height, and a commanded descent is
compared against the expected one with FD_ALT_LOSS as margin.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Andrea Bernasconi <andrea.bernasconi@auterion.com>
* fix(failure_detector): ignore stale descent setpoint in altitude loss check
Without a height setpoint the reference is lowered by the commanded
descent rate. If position control stopped publishing while a descent
was commanded, the last vz was integrated indefinitely, lowering the
reference and masking the altitude loss the detector should catch.
Only integrate the commanded descent while the setpoint is fresh
(within 500 ms of the position estimate); otherwise the reference is
held at the best altitude reached.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Andrea Bernasconi <andrea.bernasconi@auterion.com>
* docs(safety): describe altitude loss reference for manual commands
The altitude loss trigger is no longer measured only against an
altitude setpoint. Explain that manual climbs and descents are covered
and how a commanded descent lowers the reference.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Andrea Bernasconi <andrea.bernasconi@auterion.com>
* fix(commander): Add a margin to avoid small error accumulation
* fix(failure_detector): keep the altitude loss reference when the setpoint follows the vehicle
In auto modes emergency braking keeps the altitude setpoint on the vehicle
while it falls. The setpoint dragged the reference down with it, and every
time it ended up just below the vehicle the reference was reset, so a free
fall during a mission was not detected.
The reference now only moves down at the commanded descent rate, and it is
kept while the vehicle falls faster than allowed even if it is above the
setpoint.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Andrea Bernasconi <andrea.bernasconi@auterion.com>
* style(failure_detector): shorten altitude loss reference comment
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Andrea Bernasconi <andrea.bernasconi@auterion.com>
* style(failure_detector): name altitude loss constants as constants
Also document the 2 m/s descent rate margin.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Andrea Bernasconi <andrea.bernasconi@auterion.com>
* fix(failure_detector): apply the descent rate margin once
The commanded descent rate already includes the margin, adding it again
meant a fall up to 2 m/s faster than the reference moves down, with the
setpoint kept on the vehicle, reset the reference instead of being
detected.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Andrea Bernasconi <andrea.bernasconi@auterion.com>
---------
Signed-off-by: Andrea Bernasconi <andrea.bernasconi@auterion.com>
Review fixes for the battery failsafe docs. The DroneCAN case was
wrong: batteries sending only BatteryInfo give no remaining flight time,
so distance-aware return never triggers for them. Also fixes the
COM_ARM_BAT_MIN default (-1 uses BAT_CRIT_THR) and a duplicate anchor,
plus wording and capitalisation.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
"Distance-aware return" says what sets it apart from the battery level
failsafe: the return starts earlier the further away the vehicle is.
The COM_LOW_BAT_ACT option labels now name the trigger first, then the
action ("Critical level return, Emergency level land"), and the long
description explains how each level is determined.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Andrea Bernasconi <andrea.bernasconi@auterion.com>
"Bingo fuel" is military aviation jargon most PX4 users do not know, and
"fuel" is misleading for batteries. Smart Return describes what it does
and follows the "Return" terminology used for the mode since #28543.
Returning on low remaining flight time is now opt-in via the new
COM_LOW_BAT_ACT options 5 and 6, so options 0 to 4 keep their existing
behaviour and only warn, as COM_FLTT_LOW_ACT did by default. This keeps
the value 4 (terminate at emergency level) added on main unchanged.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Andrea Bernasconi <andrea.bernasconi@auterion.com>
Explain how to pick uXRCE-DDS or Zenoh in the prebuilt SITL packages
and containers (PX4_ROS2_MIDDLEWARE, ZENOH_ENABLE, PX4_ZENOH_LOCATOR),
how to run the Zenoh router, and what Zenoh does not support yet:
multiple instances and time synchronization with ROS, which the
navigation interfaces need.
Point the Zenoh and ROS 2 guides at the regular SITL targets instead of
px4_sitl_zenoh, link the uXRCE-DDS startup to px4-rc.uxrce_dds, and
describe the Zenoh leg of the ROS integration CI.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Beniamino Pozzan <beniamino.pozzan@gmail.com>
* docs(boards): restructure ARKV6X page to the board page template
Move the existing content into the flight-controller page template's
sections, headings and anchors, with no change to what the page says,
so that the content additions that follow can be reviewed on their own.
The flat Sensors, Microprocessor, Other Features, Power Requirements and
Additional Information lists become Specifications sub-sections, Where to
Buy moves after them, and See Also becomes Further Information. Port
labels are in code style, and headings, units and spelling follow the
docs style guide. No page links to the anchors that changed.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
* docs(boards): add ARKV6X specifications, PWM outputs and setup sections
Fill in the sections the board page template expects, from the board
source (boards/ark/fmu-v6x) and ARK's own documentation.
- Specifications: core, IO processor, sensor buses, the IIM-42653
Extended Range variant, interface counts, power monitoring and
operating temperature
- PWM Outputs: FMU outputs, DShot and bidirectional DShot support,
timer groups, PX4IO outputs on carriers that have one, and the
FMU_CAP capture channel
- Power, Voltage Ratings, Ethernet, SD Card, Assembly (Radio Control,
GPS & Compass, Telemetry, CAN) and Debug Port, describing the ARK PAB
Carrier where the connectors depend on the carrier
- Serial Port Mapping: flow control column, and GPS1 label
- Version badge, firmware build tip, and links to ARK's current docs,
datasheet and 3D model
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
* docs(boards): fix ARKV6X version badge and voltage ratings
The ARKV6X target was backported to the 1.13 branch and first shipped
in v1.13.1, so the badge said the board wasn't supported on v1.13.x
when it is.
The voltage ratings had been taken from the Pixhawk 6X, and claimed
the power inputs survive up to 10 V. ARK's datasheet gives 4.8 V
minimum and 5.5 V absolute maximum for the module, so use ARK's
figures, with the ARK PAB Carrier's input priority and protection
thresholds from its own page.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
* docs(boards): apply ARKV6X review style fixes
Apply the style findings from review: carrier port labels as printed
(UART4/I2C3, RC/SBUS), MCU peripheral names as plain text and device
paths in code, links for the first use of terms the page relies on,
the Radio Controller option label, the carrier's unsupported PPM and
DSM ports, Ethernet speed, mounting hole spacing, and the board's
other build targets.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
* docs(boards): apply ARKV6X review minor fixes
Link ARK's and InvenSense's canonical URLs rather than ones that
redirect, give the input voltage range from ARK's datasheet, count
power monitoring by power inputs, and drop casual italics.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
* docs(boards): apply ARKV6X review fixes
Apply the fixes from dakejahl's review of #29587, checked against the
carrier schematic and the board source. Correct the stale ARK PAB Carrier
voltage thresholds and warn that inputs above the module's 5.5 V absolute
maximum still pass through. Note that the Extended Range needs v1.14.
Cover DSM binding and power on the RC/SBUS port, FMU_CAP as a PWM output,
encrypted_logs output labelling, and INA238 setup for the 12S PAB power
module. Format the USB pin table on the PAB page.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
* docs(boards): apply ARKV6X board review fixes
A board docs review against the board source and sibling pages found
that the ARKV6X Ethernet uses a static 192.168.0.4 address with no DHCP,
so the defaults on the linked Ethernet setup page don't apply. It also
found that the DSM port can't be read in any build, because it carries
only a timer capture pin, and that the encrypted_logs build loses the
carrier's PX4IO outputs and RC input as well as the output labels. Align
the reference-design and standards links, Ethernet speed and capture-pin
details with the FMUv6X sibling pages, and give the RC/SBUS connector type
from ARK.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
---------
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
* feat(uxrce_dds_client): accept RTCM corrections from ROS 2
ROS 2 setups that need RTK had to keep a MAVLink link beside DDS just for GPS_RTCM_DATA. Routing by device_id gives each DDS source its own rtcm_corrections instance, so two publishers never interleave their byte streams. The DDS side needs no framing: the injectors reframe the stream from arbitrary chunks.
Assisted-by: Claude:claude-opus-5-5
* docs(releases): note RTCM corrections over uXRCE-DDS
Assisted-by: Claude:claude-opus-5-5
* fix(uavcan): bound RTCM corrections length before forwarding
uXRCE-DDS is the first rtcm_corrections source that does not bound len. A ROS 2 RtcmData with len over 300 made the DroneCAN forwarder read past the data array and broadcast that memory as RTCMStream.
Assisted-by: Claude:claude-opus-5-5
* docs(msg): drop the uXRCE-DDS routing note from RtcmData
It described the client's routing rather than the message, and the device_id field comment already covers it.
Assisted-by: Claude:claude-opus-5-5
* fix(uavcan): bound moving-baseline length before forwarding
The forwarder trusted the publisher's len, the same gap just closed for rtcm_corrections. No current publisher exceeds the array, so this only keeps a future one from reading past it.
Assisted-by: Claude:claude-opus-5-5
---------
Co-authored-by: Beniamino Pozzan <beniamino.pozzan@gmail.com>
* refactor(mavlink)!: drop the deprecated float mission protocol
MISSION_ITEM and MISSION_REQUEST have been deprecated since 2020. Keeping them meant a mode flag that a single float message flipped for the next transfer, so a MISSION_REQUEST was answered with MISSION_ITEM instead of the MISSION_ITEM_INT the spec asks for, and integer items were read through float structs by pointer casts. A MISSION_REQUEST is now answered like MISSION_REQUEST_INT, and an upload that sends MISSION_ITEM is rejected with MAV_MISSION_UNSUPPORTED.
Assisted-by: Claude:claude-opus-5-5
* refactor(mavlink): say why MISSION_ITEM is still handled
The case looks like a leftover of the float protocol. It stays so a
float upload is answered with MAV_MISSION_UNSUPPORTED at once instead
of being ignored until the sync timeout. The hash static_assert now
covers y as well as x.
Assisted-by: Claude:claude-fable-5-1
* refactor(navigator): drop the route cache land item sync
Missions are only written in place to update DO_JUMP counters, and the
published land index always points at a landing item. The land item sync
therefore returned at its first check on every write.
Assisted-by: Claude:claude-opus-5-5
* refactor(navigator): drop the route cache API only tests use
No flight code borrows the mission view, reads the sync result or
invalidates the cache. A ready cache has loaded every item, so a sync
patches it like the loaded prefix. The generation now only discards
stale read responses. Tests no longer invalidate a cache that is fresh
or about to reload anyway.
Assisted-by: Claude:claude-opus-5-5
* refactor(navigator): simplify the route cache load states
A cache that is not ready loads unless a retry is scheduled, so
validation_pending only restated the retry time. Drop it, together with
what it made redundant:
- The full cache's initialized, source_valid and too_large flags become
a count of -1 and one loadable flag.
- A read response is matched by its generation alone.
- The land item guards could not fail.
safePointUpdatePending() only negated safePointsReady(), which RTL now
uses directly.
The generation is now the only filter for a stale read, so two tests
receive that read before the write, and a land test also covers a retry
that succeeds.
Assisted-by: Claude:claude-opus-5-5
---------
Co-authored-by: jonas <jonas.perolini@rigi.tech>
* fix(dshot): retry telemetry init until the motor mask is known
rc.serial issues `dshot telemetry` right after `dshot start`, and the first
Run() usually handles it before the mixer has reported the outputs.
initSettingsHandlers() then latches with an empty motor mask, so no ESC
settings handler is ever created and the EEPROM is never read.
Co-authored-by: danielbuleandra <daniel.buleandra@auterion.com>
Assisted-by: Claude:claude-fable-5-1
Signed-off-by: Jacob Dahl <dahl.jakejacob@gmail.com>
* feat(logger): log the ESC EEPROM dumps
The raw dump is logged through the existing queued esc_eeprom_read topic.
The layout depends on the ESC firmware and its EEPROM revision, so decoding
happens offline in Tools/esc_eeprom_decode.py against the schema the ESC
vendor publishes.
A subscriber that joins after the first publish only sees the newest queued
entry. The logger subscribes on a sweep that can lag a new topic by half a
second while all ESCs answer within milliseconds of each other, so the topic
is advertised when the settings handlers are created, well before the first
request goes out at ESC_INIT_TELEM_DELAY.
Co-authored-by: danielbuleandra <daniel.buleandra@auterion.com>
Assisted-by: Claude:claude-fable-5-1
Signed-off-by: Jacob Dahl <dahl.jakejacob@gmail.com>
* feat(dshot): publish and refresh cached ESC settings
Logs can start after boot or during flight, so cached settings must be published independently of arming. The queue must retain a complete set of ESC dumps for the logger and MAVLink stream.
Keep programming uninterrupted and cached data valid across saves and reconnects. Failed reads remain pending with spaced retries so one unresponsive ESC cannot starve the rest.
Signed-off-by: Jacob Dahl <dahl.jakejacob@gmail.com>
Assisted-by: Codex
* fix(tools): decode repeated ESC dumps across firmware layouts
Logs contain repeated dumps and may mix EEPROM layouts. Collapse unchanged samples, apply the schema's version bounds and disabled values, and keep overlays immutable so one ESC cannot change another's decoding.
Signed-off-by: Jacob Dahl <dahl.jakejacob@gmail.com>
Assisted-by: Codex
* fix(dshot): bound ESC settings read retries
A pending settings read blocks the telemetry round-robin until it completes or times out, and the retry spacing was kept per ESC. With several ESCs that never answer, reads ran back to back, telemetry went stale and the arming check reported every ESC offline.
Space retries across all ESCs, give up on one after three failed reads until it reconnects or is asked for again, and time a read out at 100 ms: AM32 answers within milliseconds of the sixth frame, and anything under the 400 ms arming-check window keeps telemetry fresh.
Assisted-by: Claude:claude-fable-5-1
Signed-off-by: Jacob Dahl <dahl.jakejacob@gmail.com>
* fix(dshot): keep programming active until the save is sent
The flag was cleared when the save command was queued, so it no longer guarded the save itself. Only the finished() gate in the vehicle command loop kept a CONFIGURE_ACTUATOR from replacing it. Clear the flag when the last save frame goes out so the guard covers the whole sequence.
Assisted-by: Claude:claude-fable-5-1
Signed-off-by: Jacob Dahl <dahl.jakejacob@gmail.com>
* fix(dshot): send each ESC EEPROM read once per MAVLink link
The once-a-second republish that keeps the dumps in every log also went out on every link with ESC_EEPROM configured, low-bandwidth ones included, one message per ESC per second. timestamp_sample records when a dump was read, so the stream forwards each read once per link and still reaches a link that connects later.
A motor waiting on an EDT retry or out of EDT attempts took the command slot without sending anything, so settings reads never ran while any ESC left EDT unconfirmed. Vehicle commands now wait for an outstanding settings read, which ends within 100 ms, instead of CONFIGURE_ACTUATOR being rejected.
Assisted-by: Claude:claude-opus-5-5
* fix(msg): queue one ESC EEPROM dump per esc_status ESC
The republish queues every cached dump at once, so the queue needs one entry per ESC and no more. DSHOT_MAX_MOTORS is capped at CONNECTED_ESC_MAX, and the static_assert in AM32Settings.cpp keeps the two in step.
Assisted-by: Claude:claude-opus-5-5
* fix(dshot): mark the settings save explicitly
Programming ended when any finished command carried the value 12, which the address and value frames do whenever they write offset 12 (active brake power) or a value of 12. The write then stopped part way, with the ESC still in programming mode and the next write resuming mid-sequence.
Assisted-by: Claude:claude-opus-5-5
* fix(dshot): keep settings requests and writes to configured motors
An all-ESC save requested settings for every motor slot, and the single-ESC request and write paths took any index below the motor limit. Reads only go to motors with a settings handler, so the other bits stayed pending in dshot status forever. A write to an index with no output was never sent, so the command never finished and blocked every later command and the serial telemetry until reboot.
Assisted-by: Claude:claude-opus-5-5
* docs(dshot): describe the logged ESC settings and their decoding
The page said the settings are only read at boot and only reach a ground station.
Assisted-by: Claude:claude-opus-5-5
* feat(dshot): set the ciclicity to 10s for eeprom logging
---------
Signed-off-by: Jacob Dahl <dahl.jakejacob@gmail.com>
Co-authored-by: danielbuleandra <daniel.buleandra@auterion.com>
* fix(navigator): keep RTL using the checked mission after a Home update
Since 25a903f403 (#27804), RTL uses the mission only while the mission
check result carries the current Home update counter. Mission reruns
the check only for a new mission or fence, or when Mission mode
activates, but Commander also updates Home at arming, at takeoff
outside a mission, when the disarmed vehicle is moved, on the GNSS
altitude correction in the first 120 s after takeoff and on DO_SET_HOME.
After any of these, and until the check ran again, RTL_TYPE 2 and 4
returned directly instead of along the mission, types 1 and 3 ignored
the mission landing and the remaining time estimate used the direct
path. Type 1 is the FW and VTOL default, so every FW or VTOL that armed
outside Mission ignored its mission landing.
Match only the mission and fence IDs, so a Home update leaves the
verdict in place as it did before 25a903f403. Rechecking on every Home
update instead would recheck in flight: the RTL mission modes inherit
MissionBase::on_inactive() and run every cycle, so even the inactive
Return mode would rerun the check, and a check that now fails makes
Commander fail over out of Mission.
Assisted-by: Claude:claude-opus-5-5
* fix(navigator): let Return's mission modes keep Mission's verdict
RTL creates a new mission-based Return mode whenever the return type
changes, for example when RTL_TYPE 4 switches from the reverse to the
forward mission. The new mode starts with its mission check unchecked,
so its first cycle reruns the check if Home was updated since Mission
checked the mission. Before the previous commit RTL used the mission
only while the result carried the current Home counter; now it also
creates these modes after a Home update, in flight too. There a
recheck with the new Home can reject the mission being flown: an
absolute takeoff altitude now below Home, GF_MAX_HOR_DIST or
GF_MAX_VER_DIST measured from the new Home over items already flown,
or a landing relative to Home now above its absolute approach. The
result is shared, so Commander would fail over out of Mission, and a
Return that creates the mode at activation would loiter instead of
following the mission.
RTL creates these modes only for a mission and fence that Mission has
already checked, so start them with the check complete. A new mission
or fence still triggers a check through the existing path, and in
flight a Home update keeps the verdict, as it does for Mission.
A mode created at Return activation, or in the last inactive cycle
before it, also no longer reloads its items in its first active cycle.
On the ground that reload started the mission that on_activation() had
just declined because the vehicle is landed (for RtlDirectMissionLand,
its landing).
Assisted-by: Claude:claude-opus-5-5
* fix(navigator): recheck the mission when armed on the ground
Mission checks the mission when the mission or fence changes and when
Mission mode starts, not when Home is updated, and RTL now keeps that
verdict after a Home update. Home follows the disarmed vehicle and is
set again at arming and on DO_SET_HOME, so a verdict from an older
Home can be wrong for the Home the vehicle takes off from. For example
a fixed-wing landing relative to Home ends up above its absolute
approach when Home moves up, which
FeasibilityChecker::checkFixedWingLandApproach() rejects, yet Return
with RTL_TYPE 1 (the fixed-wing and VTOL default) would fly it.
Mission, which owns the check, now asks for a recheck when it is armed
on the ground before takeoff and the verdict was computed with an
older Home. The existing path reruns the check and, if Mission is
active, reloads its items. While disarmed the verdict is kept, so
moving the vehicle around does not recheck on every Home update. No
state is needed: Commander clears takeoff_time only at disarm, and the
land detector reports the takeoff before Commander sets Home for it,
so a Home update in flight or after a landing keeps the verdict.
So on the ground the check reruns once armed; in flight a Home update
keeps the verdict, and relative altitudes (also Return's mission
landing) follow the current Home, as for an active Mission.
Assisted-by: Claude:claude-opus-5-5
* docs(navigator): correct why RTL does not compare Home
The comment said a Home update never re-runs the mission check, but
since the previous commit Mission rechecks once armed on the ground.
Assisted-by: Claude:claude-opus-5-5
* refactor(navigator): clarify intent behind check
---------
Co-authored-by: jonas <jonas.perolini@rigi.tech>
* docs(releases): note that v1.17 parameter files are not migrated
The upgrade guide calls several renamed parameters auto-migrated. That
holds only when PX4 upgrades the parameters stored on the vehicle;
loading a parameter file saved on v1.17 in QGroundControl sets each
parameter by name, so values under old names are dropped and RC*_REV
saved as -1.000000 is loaded as 0.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: A.Burak Tektas <15087318+Abtektas@users.noreply.github.com>
* docs(releases): add failsafe, parachute and default changes to the upgrade guide
The upgrade guide does not list three changes that alter behaviour on an
upgrade from v1.17 without changing the stored parameters. Bit 1 of
COM_RCL_EXCEPT and COM_DLL_EXCEPT now covers all auto modes,
COM_PARACHUTE=1 no longer prevents arming, and FD_ACT_EN and
SENS_MAG_AUTOCAL are disabled by default.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: A.Burak Tektas <15087318+Abtektas@users.noreply.github.com>
* docs(releases): note the new EKF2_AGPn_NOISE default
Only stored values are migrated, so a vehicle on the v1.17 default of
0.9 m takes the new default of 1.0 m.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: A.Burak Tektas <15087318+Abtektas@users.noreply.github.com>
* docs(releases): cover the ESC checks that FD_ACT_EN now gates
FD_ESCS_EN was removed, so the not-all-ESCs-armed disarm now depends on
FD_ACT_EN, whose default became 0, and ESC offline and fault reports
depend on COM_ARM_CHK_ESCS. Also note that a v1.17 file loaded in
QGroundControl restores old defaults, that Land and Precision Landing
ignore data link loss with or without the exception bit, and link the
main PR for COM_PARACHUTE.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: A.Burak Tektas <15087318+Abtektas@users.noreply.github.com>
* docs(releases): note that COM_ARM_CHK_ESCS now triggers the actuator failsafe
With COM_ARM_CHK_ESCS set, v1.18 counts an offline ESC or any ESC fault
as a motor failure, so COM_ACT_FAIL_ACT acts in flight. v1.17 only
reported ESC faults, and item 16 recommends enabling the check.
Assisted-by: Claude:claude-opus-5-5
* docs(releases): note the ESC fault disarm that FD_ESCS_EN took with it
The v1.18 spool-up check under FD_ACT_EN only covers ESCs that are not
armed, so no setting restores the v1.17 disarm on an ESC fault.
Assisted-by: Claude:claude-opus-5-5
---------
Signed-off-by: A.Burak Tektas <15087318+Abtektas@users.noreply.github.com>
Co-authored-by: Jacob Dahl <dahl.jakejacob@gmail.com>
* feat(commander): disarm if a motor is not spinning right after arming
During the spool-up window, while landed and before takeoff is detected,
a motor that is commanded to run but never reports RPM, or reports the
motor-stuck fault, raises a new failsafe flag. The failsafe then disarms,
like the existing ESC arming and battery spool-up failures. Motors with
a NaN command are ignored.
The check runs only for rotary-wing vehicles, since it assumes the
minimum output spins the motors. It is enabled by COM_ARM_CHK_ESCS and
needs per-motor RPM telemetry. It adds no parameters; timing is a
fraction of COM_SPOOLUP_TIME: nothing is evaluated up to 50%, and the
decision is made at 80%.
Assisted-by: Claude:claude-sonnet-5-5
Signed-off-by: Beniamino Pozzan <beniamino.pozzan@auterion.com>
* feat(sih): add motor stuck failure injection
`failure motor stuck -i N` models a stuck rotor with a healthy ESC: the
motor is still commanded but produces no thrust, and the ESC stays
online reporting zero RPM. The failure detector and control allocator
are not informed, unlike `motor off` and `motor wrong`.
The failure injection catalogue now accepts STUCK for the motor unit,
and SIH zeroes the thrust of the addressed motors, which also zeroes
their reported RPM. Other environments accept the command but do not
apply it, as documented in the failure injection table.
Assisted-by: Claude:claude-sonnet-5-5
Signed-off-by: Beniamino Pozzan <beniamino.pozzan@auterion.com>
* feat(sih): publish esc status for standard VTOL pusher
add case in motor_inded_from_actuator for StandardVTOL
Signed-off-by: Beniamino Pozzan <beniamino.pozzan@auterion.com>
* chore(params): increase COM_SPOOLUP_TIME default value to 2 seconds
This is to ensure that the motor has enough time to try to start
and the stuck-detection logic does not return false negative
when an attemp of spin is marked as healty motor
Signed-off-by: Beniamino Pozzan <beniamino.pozzan@auterion.com>
---------
Signed-off-by: Beniamino Pozzan <beniamino.pozzan@auterion.com>
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>