* feat(msg): rename rover throttle setpoint to surface_vehicle_*
The throttle setpoint was the last rover topic shared by rovers and boats
without the surface_vehicle_* prefix decided in #29524. Rename
RoverThrottleSetpoint to SurfaceVehicleThrottleSetpoint and the
TYPE_ROVER_THROTTLE_* setpoint types to TYPE_SURFACE_VEHICLE_THROTTLE_*.
The type values are unchanged.
The topic rename breaks ROS 2 users anyway, so also shorten the fields of
the throttle and speed setpoints to x and y: the message name already says
what the value is and [@frame Body] states the frame.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Michael Fritsche <frimi999@gmail.com>
* fix(zenoh): bring surface_vehicle rename to the zenoh dds topics
* fix(concept): rename rover throttle setpoint to surface_vehicle_* in navigation terminology
* fix(tools): update px4-ros2-interface-lib pin
* docs(msg): describe sideways fields as omnidirectional, not mecanum
The surface vehicle messages are shared by rovers and boats, and the lateral
axis applies to any vehicle that can move sideways, not only mecanum rovers.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Michael Fritsche <frimi999@gmail.com>
* docs(ros2): use the surface vehicle setpoint type names of the interface lib
The pinned px4-ros2-interface-lib names the rover setpoint types
SurfaceVehicle*SetpointType. The table and the example reference still used
the old Rover*SetpointType class names, which do not exist in that version.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Michael Fritsche <frimi999@gmail.com>
* feat(msg)!: rename surface vehicle throttle setpoint to thrust setpoint
The setpoint is a normalized force command along the body x and y axes,
which is a thrust, not a throttle. Throttle stays the name for the motor
command the actuator control derives from it.
surface_vehicle_throttle_setpoint is now surface_vehicle_thrust_setpoint
(SurfaceVehicleThrustSetpoint), and SetpointConfig
TYPE_SURFACE_VEHICLE_THROTTLE_* are now TYPE_SURFACE_VEHICLE_THRUST_*
(same values). The px4-ros2-interface-lib pin follows the matching rename
there.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Michael Fritsche <frimi999@gmail.com>
* fix(tools): update px4-ros2-interface-lib pin
* fix(commander): do not enable velocity control for surface vehicle thrust setpoints
The SurfaceVehicleThrust* setpoint types enabled the velocity flag, taken
over from the original interface lib configuration. Nothing in these types
uses velocity, and offboard mode maps the same combinations without it.
The flag kept the rover speed controller running: switching from a
SurfaceVehicleSpeed* to a SurfaceVehicleThrust* type sets the same flags,
so the controllers were not reset and a stale speed setpoint kept
overriding the commanded thrust. It also made external modes that only
command thrust require a local position estimate.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Michael Fritsche <frimi999@gmail.com>
* docs(msg): apply review suggestions for the surface vehicle setpoints
Add long descriptions to the thrust and speed setpoints and the speed
status, name modules instead of C++ classes, and use single spaces before
field comments. Rename the speed status PID integrals from pid_throttle_*
to pid_thrust_*, since the speed controller drives the thrust setpoint.
Update the docs and the rover control structure diagram for the thrust
setpoint and omnidirectional vehicles, note the Rover*SetpointType names of
PX4 v1.17 and v1.18, and add the ROS 2 release note.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Michael Fritsche <frimi999@gmail.com>
---------
Signed-off-by: Michael Fritsche <frimi999@gmail.com>
* docs(msg): clarify RoverPositionSetpoint field descriptions
* feat(rover): introduce a course parameter to get rid of the course-hold workaround hack (#29245)
* fix(ros2): update ros2 interface lib pin to include course and target_ned in RoverPositionSetpoint
* style(msg): use single space before comments in RoverPositionSetpoint
The column padding triggers the msg doc generator's multiple-whitespace
note on every field.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
* fix(msg): update RoverPositionSetpoint descriptions
* feat(msg): add SurfaceVehicleCourseSetpoint
* fix(repositories): update px4 ros2 interface lib version
* fix(msg): add comment that yaw in RoverPositionSetpoint msg is currently not used
* fix(msg): rename surface_vehicle_course_setpoint to planar_course_setpoint
* fix(rover): keep the course line while a course setpoint is streamed
A PlanarCourseSetpoint without start_ned re-anchored the line at the
vehicle position on every message. Publishers that stream the setpoint,
the usual pattern over ROS 2, therefore never got cross-track error
corrected: in SITL the rover drifted 3.8 m off course over 54 m. Keep the
current line while the same course is published without a start
position, and only re-anchor when the course changes.
Also document that a NaN course leaves the position controller idle and
that yaw is currently unused, matching RoverPositionSetpoint.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Michael Fritsche <frimi999@gmail.com>
* fix(msg): rename planar_course_setpoint to ugv_usv_course_setpoint
* docs(msg): add documentation for UgvUsvCourseSetpoint
* feat(rover): proper guided course implementation
* fix(rover): rename course setpoint cruising_speed param to speed
* fix(msgs): rename ugv_usv_course_setpoint.msg to surface_vehicle_course_setpoint.msg
* docs(rover): clarify course setpoint wording
Doc review fixes for the course hold docs and message comments:
unclear antecedents, a misplaced modifier, a missing verb, and the
pure pursuit sentence separated from the course setpoint text it no
longer described. The yaw @invalid tag now matches in both messages,
since no controller reads the field.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
* Apply suggestion from @hamishwillee
* docs(rover): fix course tracking formulation for the different rover types
* fix(rover): maintain current speed upon guided course mode entry
* docs(rover): clarify guided course mode documentation.
* fix(rover): handle nav_state_land in rovers
* fix(rovers): polish the used terminology
* docs(rover): switch to list for guided course mode usable commands
---------
Signed-off-by: Hamish Willee <hamishwillee@gmail.com>
Signed-off-by: Michael Fritsche <frimi999@gmail.com>
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Picks up Auterion/px4-ros2-interface-lib#231, which makes the
integration test helper wait for command acks and retry. Commands
reach PX4 over a best-effort stream, and a lost command made
ModesTest.runModeTests hang until its 120 s timeout once in a while.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Julian Oes <julian@oes.ch>
Provide a supported Jazzy environment for SIH/Gazebo development and source builds, with pinned tooling and reproducible multi-architecture image publishing. Separate package and container assets from ROS source preparation, and keep checkout workspaces fresh through a Python CLI.
Assisted-by: Copilot:gpt-6-astra