ci(px4io): fail the IO firmware check instead of only warning

A passing job with a warning annotation is easy to miss, which defeats the
purpose of the check. Fail the job so stale IO firmware gets regenerated in
the PR that changes its dependencies.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Julian Oes <julian@oes.ch>
This commit is contained in:
Julian Oes committed 2026-11-20 12:08:09 +13:00
1 parent a88edf1abe
commit aa34d65fcb
1 file changed
+3 -2
+3 -2
View File
@@ -50,7 +50,7 @@ jobs:
# The committed px4io firmware binaries must match what the current sources build to.
# The build is reproducible with a fixed toolchain, so a mismatch means a dependency
# changed without "make px4io_update". This only warns, it does not fail the job.
# changed without "make px4io_update", and the job fails.
px4io_firmware:
name: IO Firmware Up To Date
runs-on: [runs-on,runner=2cpu-linux-x64,image=ubuntu24-full-x64,"run-id=${{ github.run_id }}",spot=false,extras=s3-cache]
@@ -76,7 +76,7 @@ jobs:
run: |
if ! make check_px4io; then
image="ghcr.io/px4/px4-dev:v1.17.0-rc2"
echo "::warning title=px4io firmware out of date::The committed px4io firmware does not match the current sources. Regenerate it with: PX4_DOCKER_REPO=${image} ./Tools/docker_run.sh 'make px4io_update'"
echo "::error title=px4io firmware out of date::The committed px4io firmware does not match the current sources. Regenerate it with: PX4_DOCKER_REPO=${image} ./Tools/docker_run.sh 'make px4io_update'"
{
echo "### px4io firmware out of date"
echo
@@ -86,6 +86,7 @@ jobs:
echo "PX4_DOCKER_REPO=${image} ./Tools/docker_run.sh 'make px4io_update'"
echo '```'
} >> "$GITHUB_STEP_SUMMARY"
exit 1
fi
tests: