UAV-develop/PX4-Autopilot
1
0
Fork 0
mirror of https://github.com/PX4/PX4-Autopilot.git synced 2026-09-25 03:38:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(boards/corvon): unquote BOARD_UAVCAN_INTERFACES

Browse Source 
BOARD_UAVCAN_INTERFACES is an int with a default of 2, so the quoted "1" was
not a valid value. Kconfig discarded the assignment and fell back to the
default, and 743v2 has been building with two interfaces on a board its own
header describes as "CAN (FDCAN1) - single interface".

The value reaches compiled code as -DUAVCAN_NUM_IFACES via
config_uavcan_num_ifaces, where it sizes _can_status_pub_handles[] and makes
the logger advertise two can_interface_status instances. The driver iterates
the runtime interface count rather than this constant, so nothing polls
absent hardware; the cost is a spare handle and a phantom log instance.

Verified with kconfiglib: the value now resolves to 1, matching 743v1 and
every other board that sets it. The board_config.h comment documented the
quoted form, so it is corrected too rather than left to spread.

Assisted-by: Claude:claude-opus-5
Signed-off-by: Ramon Roche <mrpollo@gmail.com>
This commit is contained in:
Ramon Roche
2026-08-19 22:57:52 -07:00
parent 8ee8a9548d
commit 8f44f9f1d3
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
boards/corvon/743v2/default.px4board
View File

@@ -6,7 +6,7 @@
CONFIG_BOARD_TOOLCHAIN="arm-none-eabi" CONFIG_BOARD_TOOLCHAIN="arm-none-eabi"
CONFIG_BOARD_ARCHITECTURE="cortex-m7" CONFIG_BOARD_ARCHITECTURE="cortex-m7"
CONFIG_BOARD_UAVCAN_INTERFACES="1" CONFIG_BOARD_UAVCAN_INTERFACES=1
CONFIG_BOARD_ROMFSROOT="px4fmu_common" CONFIG_BOARD_ROMFSROOT="px4fmu_common"
CONFIG_BOARD_ETHERNET=n CONFIG_BOARD_ETHERNET=n
CONFIG_BOARD_SERIAL_GPS1="/dev/ttyS2" CONFIG_BOARD_SERIAL_GPS1="/dev/ttyS2"

2
boards/corvon/743v2/src/board_config.h
View File

@@ -223,7 +223,7 @@
/**************************************************************************************************** /****************************************************************************************************
* CAN (FDCAN1) - single interface, statically configured via * CAN (FDCAN1) - single interface, statically configured via
* CONFIG_BOARD_UAVCAN_INTERFACES="1" in default.px4board. Do NOT define * CONFIG_BOARD_UAVCAN_INTERFACES=1 in default.px4board. Do NOT define
* UAVCAN_NUM_IFACES_RUNTIME here (that forces us to implement * UAVCAN_NUM_IFACES_RUNTIME here (that forces us to implement
* board_get_can_interfaces() at the board level). * board_get_can_interfaces() at the board level).
****************************************************************************************************/ ****************************************************************************************************/