From 8f44f9f1d3cc3ec90f222b5dae6e6b72c6358dae Mon Sep 17 00:00:00 2001 From: Ramon Roche Date: Wed, 19 Aug 2026 22:57:52 -0700 Subject: [PATCH] fix(boards/corvon): unquote BOARD_UAVCAN_INTERFACES BOARD_UAVCAN_INTERFACES is an int with a default of 2, so the quoted "1" was not a valid value. Kconfig discarded the assignment and fell back to the default, and 743v2 has been building with two interfaces on a board its own header describes as "CAN (FDCAN1) - single interface". The value reaches compiled code as -DUAVCAN_NUM_IFACES via config_uavcan_num_ifaces, where it sizes _can_status_pub_handles[] and makes the logger advertise two can_interface_status instances. The driver iterates the runtime interface count rather than this constant, so nothing polls absent hardware; the cost is a spare handle and a phantom log instance. Verified with kconfiglib: the value now resolves to 1, matching 743v1 and every other board that sets it. The board_config.h comment documented the quoted form, so it is corrected too rather than left to spread. Assisted-by: Claude:claude-opus-5 Signed-off-by: Ramon Roche --- boards/corvon/743v2/default.px4board | 2 +- boards/corvon/743v2/src/board_config.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/boards/corvon/743v2/default.px4board b/boards/corvon/743v2/default.px4board index b0029163d59..ec4e90b46e3 100644 --- a/boards/corvon/743v2/default.px4board +++ b/boards/corvon/743v2/default.px4board @@ -6,7 +6,7 @@ CONFIG_BOARD_TOOLCHAIN="arm-none-eabi" CONFIG_BOARD_ARCHITECTURE="cortex-m7" -CONFIG_BOARD_UAVCAN_INTERFACES="1" +CONFIG_BOARD_UAVCAN_INTERFACES=1 CONFIG_BOARD_ROMFSROOT="px4fmu_common" CONFIG_BOARD_ETHERNET=n CONFIG_BOARD_SERIAL_GPS1="/dev/ttyS2" diff --git a/boards/corvon/743v2/src/board_config.h b/boards/corvon/743v2/src/board_config.h index ad423f1de0f..07b7c05f513 100644 --- a/boards/corvon/743v2/src/board_config.h +++ b/boards/corvon/743v2/src/board_config.h @@ -223,7 +223,7 @@ /**************************************************************************************************** * CAN (FDCAN1) - single interface, statically configured via - * CONFIG_BOARD_UAVCAN_INTERFACES="1" in default.px4board. Do NOT define + * CONFIG_BOARD_UAVCAN_INTERFACES=1 in default.px4board. Do NOT define * UAVCAN_NUM_IFACES_RUNTIME here (that forces us to implement * board_get_can_interfaces() at the board level). ****************************************************************************************************/