mirror of
https://github.com/PX4/PX4-Autopilot.git
synced 2026-11-22 14:19:57 +08:00
Backport PRs are titled "[BACKPORT 1.18] fix(mavlink): ...". The PR title check anchors on the conventional commit type, so it fails all of them even though the header after the tag is valid. Replaying the check over the 210 PRs opened against release/1.16, release/1.17 and release/1.18, 62 fail only because of the tag. Skip a leading backport tag before validating the header. The header after the tag still has to be a conventional commit. The tag is accepted only on PRs that target a release/* branch, so a backport opened against main by mistake fails with a comment that says so. The title suggested in the failure comment keeps the tag. Assisted-by: Claude:claude-fable-5-2 Signed-off-by: Ramon Roche <mrpollo@gmail.com>
206 lines
6.8 KiB
Python
Executable File
206 lines
6.8 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
"""Validate that a PR title follows conventional commits format.
|
|
|
|
Format: type(scope): description
|
|
|
|
Can output plain text for CI logs or markdown for PR comments.
|
|
"""
|
|
|
|
import re
|
|
import sys
|
|
|
|
from conventional_commits import (
|
|
CONVENTIONAL_TYPES,
|
|
EXEMPT_PREFIXES,
|
|
parse_header,
|
|
split_backport_tag,
|
|
suggest_scope,
|
|
suggest_type,
|
|
)
|
|
|
|
RELEASE_BRANCH_PREFIX = 'release/'
|
|
|
|
|
|
def misplaced_backport(title: str, base_ref: str | None) -> str | None:
|
|
"""Explain a backport tag on a PR that does not target a release branch.
|
|
|
|
Returns None when the title has no tag, the base is a release branch, or
|
|
the base is not known.
|
|
"""
|
|
tag, _ = split_backport_tag(title)
|
|
if not tag or not base_ref or base_ref.startswith(RELEASE_BRANCH_PREFIX):
|
|
return None
|
|
return (f"The title is tagged `{tag}`, but this PR targets `{base_ref}`. "
|
|
f"Backports go to a `{RELEASE_BRANCH_PREFIX}*` branch.")
|
|
|
|
|
|
def suggest_title(title: str) -> str | None:
|
|
"""Try to suggest a corrected title in conventional commits format."""
|
|
tag, stripped = split_backport_tag(title)
|
|
if tag:
|
|
suggestion = suggest_title(stripped)
|
|
return f"{tag} {suggestion}" if suggestion else None
|
|
|
|
# Remove common bracket prefixes like [docs], [CI], etc.
|
|
bracket_match = re.match(r'^\[([^\]]+)\]\s*(.+)', stripped)
|
|
if bracket_match:
|
|
prefix = bracket_match.group(1).strip().lower()
|
|
rest = bracket_match.group(2).strip()
|
|
rest = re.sub(r'^[\-:]\s*', '', rest).strip()
|
|
if len(rest) >= 5:
|
|
# Try to map bracket content to a type
|
|
commit_type = prefix if prefix in CONVENTIONAL_TYPES else suggest_type(rest)
|
|
scope = suggest_scope(rest)
|
|
if scope:
|
|
return f"{commit_type}({scope}): {rest}"
|
|
|
|
# Already has old-style "subsystem: description" format - convert it
|
|
colon_match = re.match(r'^([a-zA-Z][a-zA-Z0-9_/\-\. ]*): (.+)$', stripped)
|
|
if colon_match:
|
|
old_subsystem = colon_match.group(1).strip()
|
|
desc = colon_match.group(2).strip()
|
|
if len(desc) >= 5:
|
|
commit_type = suggest_type(desc)
|
|
# Use the old subsystem as scope (clean it up)
|
|
scope = old_subsystem.lower().replace(' ', '_')
|
|
return f"{commit_type}({scope}): {desc}"
|
|
|
|
# No format at all - try to guess both type and scope
|
|
commit_type = suggest_type(stripped)
|
|
scope = suggest_scope(stripped)
|
|
if scope:
|
|
desc = stripped[0].lower() + stripped[1:] if stripped else stripped
|
|
return f"{commit_type}({scope}): {desc}"
|
|
|
|
return None
|
|
|
|
|
|
def check_title(title: str, base_ref: str | None = None) -> bool:
|
|
title = title.strip()
|
|
|
|
if not title:
|
|
print("PR title is empty.", file=sys.stderr)
|
|
return False
|
|
|
|
for prefix in EXEMPT_PREFIXES:
|
|
if title.startswith(prefix):
|
|
return True
|
|
|
|
if parse_header(title):
|
|
misplaced = misplaced_backport(title, base_ref)
|
|
if misplaced:
|
|
print(misplaced, file=sys.stderr)
|
|
return not misplaced
|
|
|
|
types_str = ', '.join(f'`{t}`' for t in CONVENTIONAL_TYPES.keys())
|
|
print(
|
|
f"PR title does not match conventional commits format.\n"
|
|
f"\n"
|
|
f" Title: {title}\n"
|
|
f"\n"
|
|
f"Expected format: type(scope): description\n"
|
|
f"\n"
|
|
f"Valid types: {types_str}\n"
|
|
f"\n"
|
|
f"Good examples:\n"
|
|
f" feat(ekf2): add height fusion timeout\n"
|
|
f" fix(mavlink): correct BATTERY_STATUS_V2 parsing\n"
|
|
f" ci(workflows): migrate to reusable workflows\n"
|
|
f" feat(boards/px4_fmu-v6x)!: remove deprecated driver API\n"
|
|
f"\n"
|
|
f"Bad examples:\n"
|
|
f" fix stuff\n"
|
|
f" Update file\n"
|
|
f" ekf2: fix something (missing type prefix)\n"
|
|
f"\n"
|
|
f"See the contributing guide for details:\n"
|
|
f" https://github.com/PX4/PX4-Autopilot/blob/main/CONTRIBUTING.md#commit-message-convention\n",
|
|
file=sys.stderr,
|
|
)
|
|
return False
|
|
|
|
|
|
def format_markdown(title: str, base_ref: str | None = None) -> str:
|
|
"""Format a markdown PR comment body for a bad title."""
|
|
misplaced = misplaced_backport(title, base_ref) if parse_header(title) else None
|
|
if misplaced:
|
|
return '\n'.join([
|
|
"## \u274c Backport PR does not target a release branch",
|
|
"",
|
|
misplaced,
|
|
"",
|
|
"**To fix this:** click the ✏️ next to the PR title and change the "
|
|
"base branch, or remove the tag from the title.",
|
|
"",
|
|
"See [CONTRIBUTING.md](https://github.com/PX4/PX4-Autopilot/blob/main/CONTRIBUTING.md#pr-titles) "
|
|
"for details.",
|
|
"",
|
|
"---",
|
|
"*This comment will be automatically removed once the issue is resolved.*",
|
|
])
|
|
|
|
lines = [
|
|
"## \u274c PR title needs conventional commit format",
|
|
"",
|
|
"Expected format: `type(scope): description` "
|
|
"([conventional commits](https://www.conventionalcommits.org/)).",
|
|
"",
|
|
"**Your title:**",
|
|
f"> {title}",
|
|
"",
|
|
]
|
|
|
|
suggestion = suggest_title(title)
|
|
if suggestion:
|
|
lines.extend([
|
|
"**Suggested fix:**",
|
|
f"> {suggestion}",
|
|
"",
|
|
])
|
|
|
|
lines.extend([
|
|
"**To fix this:** click the ✏️ next to the PR title "
|
|
"and update it.",
|
|
"",
|
|
"See [CONTRIBUTING.md](https://github.com/PX4/PX4-Autopilot/blob/main/CONTRIBUTING.md#commit-message-convention) "
|
|
"for details.",
|
|
"",
|
|
"---",
|
|
"*This comment will be automatically removed once the issue is resolved.*",
|
|
])
|
|
|
|
return '\n'.join(lines)
|
|
|
|
|
|
def main() -> None:
|
|
import argparse
|
|
parser = argparse.ArgumentParser(description='Check PR title format')
|
|
parser.add_argument('title', help='The PR title to validate')
|
|
parser.add_argument('--base-ref', metavar='BRANCH',
|
|
help='Branch the PR targets; a backport tag is only '
|
|
f'accepted on {RELEASE_BRANCH_PREFIX}* branches')
|
|
parser.add_argument('--markdown', action='store_true',
|
|
help='Output markdown to stdout on failure')
|
|
parser.add_argument('--markdown-file', metavar='FILE',
|
|
help='Write markdown to FILE on failure')
|
|
args = parser.parse_args()
|
|
|
|
passed = check_title(args.title, args.base_ref)
|
|
|
|
if not passed:
|
|
md = format_markdown(args.title, args.base_ref)
|
|
if args.markdown:
|
|
print(md)
|
|
if args.markdown_file:
|
|
with open(args.markdown_file, 'w') as f:
|
|
f.write(md + '\n')
|
|
elif args.markdown_file:
|
|
with open(args.markdown_file, 'w') as f:
|
|
pass
|
|
|
|
sys.exit(0 if passed else 1)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
main()
|