Files
PX4-Autopilot/docs
Isak Åslund b364d30a88 fix(mc_att_control): reject invalid attitude setpoints (#29008)
* fix(mc_att_control): ignore invalid attitude setpoints in the reference model

Since the reference model (2a0e048171, PR #27255) the controller tracks _q_ref,
which is integrated from its previous value and only snapped to the setpoint on
the first call. A single attitude setpoint with a zero or non-finite quaternion
(normalizing a zero quaternion gives NaN) therefore makes _q_ref NaN for the rest
of the boot: every later setpoint is ignored, the rate setpoint stays NaN and the
vehicle has no attitude control, even after a mode switch. Before the reference
model the controller used q_d directly, so a bad sample only lasted one cycle.

One MAVLink SET_ATTITUDE_TARGET with q = [0, 0, 0, 0] in Offboard reproduces it
in SIH: vehicle_rates_setpoint stays NaN and the vehicle no longer responds to
the sticks after switching to Position mode.

Ignore setpoints and heading-reset deltas that are zero or non-finite, keeping
the last valid reference, and snap the reference to the next valid setpoint if
it ever becomes non-finite.

Signed-off-by: Isak Åslund <isak.aslund@airolit.com>

* fix(mc_att_control): drop the whole attitude setpoint when its quaternion is invalid

When the controller rejects an invalid quaternion, the thrust and timestamp
from the same message were still applied. The vehicle then flew the last
valid attitude with thrust from a message that cannot be trusted.

setAttitudeSetpoint() now returns whether the setpoint was accepted. The
thrust and the setpoint timestamp are only updated when it was. Keeping the
timestamp also gives the next valid setpoint the true dt since the last
accepted one.

Signed-off-by: Isak Åslund <isak.aslund@airolit.com>

* fix(mc_att_control): reject overflowing quaternions and drop invalid SET_ATTITUDE_TARGET

Review follow-ups:
- Validate the setpoint through its norm. A quaternion with a finite component
  above ~1.8e19 (e.g. q = (1e20, 0, 0, 0)) passed isAllFinite(), its norm
  overflowed to inf and normalizing it gave a zero quaternion. As the first
  setpoint this made the reference NaN for the next setpoint. One finite norm
  check rejects NaN, inf, zero and overflow.
- Drop the ref_valid / dt finiteness recovery branch: with every input of the
  reference model validated it cannot be reached, and it costs flash.
- Drop the adaptAttitudeSetpoint() guard: no estimator publishes an invalid
  delta with a changed reset counter, and it only protected the reference,
  not the yaw setpoint and StickYaw that use the same delta.
- MAVLink SET_ATTITUDE_TARGET: drop a message with an unusable q before
  publishing offboard_control_mode. Otherwise a companion streaming only
  invalid quaternions keeps the offboard heartbeat alive and the vehicle holds
  the last valid tilt and thrust indefinitely without triggering
  COM_OF_LOSS_T.

Signed-off-by: Isak Åslund <isak.aslund@airolit.com>

* docs(offboard): note that SET_ATTITUDE_TARGET with an invalid q is dropped

Since the previous commit, such a message no longer counts as the offboard
signal, which is a behavior change MAVLink users can see. Also name the 1e-3
norm threshold in the setAttitudeSetpoint() doc, and point the MAVLink and
controller checks at each other: if the MAVLink threshold were lowered below
the controller's, messages the controller drops would keep offboard alive.

Signed-off-by: Isak Åslund <isak.aslund@airolit.com>

---------

Signed-off-by: Isak Åslund <isak.aslund@airolit.com>
(cherry picked from commit 7902349f7a)
2026-11-16 07:26:09 -08:00
..
2026-11-11 22:48:19 +00:00
…
…
…
2026-02-13 08:55:29 +11:00
…
…

PX4 User Guide

This repo contains the source code for the PX4 User Guide.

Note

Contributions and Translations to this guide are very welcome!