Files
PX4-Autopilot/test/mavsdk_tests/test_multicopter_basics.cpp
Jacob Dahl a617a1433c fix(mavsdk_tests): stabilize takeoff-and-hold altitude check
wait_until_altitude() returns on the first touch of the target band while
the vehicle is still climbing, so start_checking_altitude() latched the hold
reference mid-climb. The normal takeoff overshoot (~0.24 m) and slow VTOL
settle then exceeded the 0.15 m tolerance and the standard_vtol job failed
intermittently.

Wait for the overshoot to damp before capturing the reference, and restore
the 0.2 m tolerance established in #26106 (a later SIH rewrite had tightened
it back to 0.15 m). Steady-state hover holds to ~0.05 m, so the check stays
sensitive to real altitude-hold failures.

Signed-off-by: Jacob Dahl <dahl.jakejacob@gmail.com>
2026-07-22 16:17:17 +12:00

76 lines
3.1 KiB
C++

/****************************************************************************
*
* Copyright (c) 2021 PX4 Development Team. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
* 3. Neither the name PX4 nor the names of its contributors may be
* used to endorse or promote products derived from this software
* without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
* FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
* COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
* OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
* AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
* ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*
****************************************************************************/
#include <thread>
#include <chrono>
#include <math.h>
#include "autopilot_tester.h"
TEST_CASE("Takeoff and hold position", "[multicopter][vtol]")
{
const float takeoff_altitude = 10.f;
// Takeoff overshoot plus the slow VTOL settle can drift the hold altitude by
// ~0.1 m; keep the tolerance above that so a normal hover doesn't trip it.
const float altitude_hold_tolerance = 0.2f;
AutopilotTester tester;
tester.connect(connection_url);
tester.wait_until_ready();
tester.set_takeoff_altitude(takeoff_altitude);
tester.store_home();
// The sleep here is necessary for the takeoff altitude to be applied properly
tester.sleep_for(std::chrono::seconds(1));
// Capture altitude before takeoff
std::array<float, 3> initial_position = tester.get_current_position_ned();
float ground_altitude = -initial_position[2];
// Takeoff
tester.arm();
tester.takeoff();
tester.wait_until_hovering();
tester.wait_until_altitude(ground_altitude + takeoff_altitude, std::chrono::seconds(15), 0.1f);
// wait_until_altitude() returns on the first touch of the target band, while
// the vehicle is still climbing. Let the takeoff overshoot damp out so the
// hold reference is captured at the settled hover altitude, not mid-climb.
tester.sleep_for(std::chrono::seconds(5));
// Monitor altitude and fail if it exceeds the tolerance
tester.start_checking_altitude(altitude_hold_tolerance);
tester.sleep_for(std::chrono::seconds(15));
}