mirror of
https://github.com/PX4/PX4-Autopilot.git
synced 2026-05-25 05:20:06 +08:00
* fix(cmake): use Python3 module; cache PYTHON_EXECUTABLE properly The legacy `find_package(PythonInterp 3)` is deprecated (warned with noisy CMP0148 by cmake 3.27+, currently visible on Ubuntu 24.04 CI runs). It also stores its result as PYTHON_EXECUTABLE without a proper CACHE type, which interacts badly with the Makefile's `cmake-cache-check`. `cmake -L` skips UNINITIALIZED entries, so the `-DPYTHON_EXECUTABLE=...` passed by the top-level Makefile is never matched in the cache and every invocation forces a full reconfigure. Switch to `find_package(Python3 COMPONENTS Interpreter REQUIRED)`, then bridge to the legacy `PYTHON_EXECUTABLE` name that the rest of the codebase still references. Promote it to a CACHE FILEPATH entry so cmake -L lists it, preserving any user-supplied value verbatim (find_package(Python3) canonicalises e.g. bin/python3 to bin/python3.13, defeating a string-based cache match). Signed-off-by: Daniel Fanache <dan@rts.ro> * fix(cmake): promote CONFIG to CACHE STRING for incremental builds When CONFIG is passed via `-DCONFIG=...` on the cmake command line, it is stored as an UNINITIALIZED cache entry. `cmake -L` skips UNINITIALIZED entries by design, so the Makefile's `cmake-cache-check` (which uses `cmake -L` to diff desired vs cached options) never finds CONFIG in the output, concludes the cache is stale, and triggers a full reconfigure on every `make <target>` invocation. If a config identifier is given, we force promote it to CACHE STRING. This preserves the user supplied value as it was, while making it visible to `cmake -L`, so the cache-check succeeds when nothing has changed. Signed-off-by: Daniel Fanache <dan@rts.ro> * fix(cmake): track default.px4board as a configure dependency Non-default labels merge `default.px4board` + `{label}.px4board` via `merge_config.py`, but only the label file was listed as a configure dependency. Changes to `default.px4board` were silently ignored until a clean build, which is surprising and easy to debug for hours. Register `default.px4board` as a CMAKE_CONFIGURE_DEPENDS in the non-default-label branch so edits trigger reconfigure as expected. Signed-off-by: Daniel Fanache <dan@rts.ro> * fix(cmake): correct NuttX apps/library build dependency tracking Three dependency graph defects in the libapps.a and per NuttX library custom_commands caused either spurious full rebuilds or stale outputs on incremental builds. (1) `builtin_list.h` and `builtin_proto.h` are regenerated by the apps build from `px4.bdat`/`px4.pdat` on every invocation. They were included in `nuttx_apps_files`, so on each build we saw them as changed inputs and re-triggered the apps target perpetually. Exclude them with a `list(FILTER)`. (2) libapps.a's custom_command lacked `px4.bdat`/`px4.pdat` as dependencies, so module additions or renames (which regenerate those registries) did not propagate to a rebuild of the builtin command table. Add them to DEPENDS. (3) NuttX's recursive make does not always notice that `builtin_list.h` has been regenerated and that `builtin_list.c` therefore needs recompiling. Touch `builtin_list.c` so NuttX's make picks up the indirect change. Additionally, drop the destructive cleanup COMMANDs that ran at the start of libapps.a and each per-library custom_command (`remove -f *.a`, `find ... -delete *.o`). These were workarounds for the now fixed dependency tracking; without them removed, they would also force unnecessary full rebuilds every time. Signed-off-by: Daniel Fanache <dan@rts.ro> --------- Signed-off-by: Daniel Fanache <dan@rts.ro> Co-authored-by: Ramon Roche <mrpollo@gmail.com>
126 lines
5.4 KiB
CMake
126 lines
5.4 KiB
CMake
############################################################################
|
|
#
|
|
# Copyright (c) 2019 PX4 Development Team. All rights reserved.
|
|
#
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions
|
|
# are met:
|
|
#
|
|
# 1. Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
# 2. Redistributions in binary form must reproduce the above copyright
|
|
# notice, this list of conditions and the following disclaimer in
|
|
# the documentation and/or other materials provided with the
|
|
# distribution.
|
|
# 3. Neither the name PX4 nor the names of its contributors may be
|
|
# used to endorse or promote products derived from this software
|
|
# without specific prior written permission.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
|
|
# FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
|
|
# COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
|
|
# BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
|
|
# OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
|
|
# AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
|
|
# ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
# POSSIBILITY OF SUCH DAMAGE.
|
|
#
|
|
############################################################################
|
|
|
|
# find PX4 config
|
|
# look for in tree board config that matches CONFIG input
|
|
|
|
if(NOT CONFIG)
|
|
# default to px4_ros2_default if building within a ROS2 colcon environment
|
|
if(("$ENV{COLCON}" MATCHES "1") AND ("$ENV{ROS_VERSION}" MATCHES "2"))
|
|
set(CONFIG "px4_ros2_default" CACHE STRING "desired configuration")
|
|
else()
|
|
set(CONFIG "px4_sitl_default" CACHE STRING "desired configuration")
|
|
endif()
|
|
else()
|
|
# Promote CONFIG from UNINITIALIZED (set by -D on command line) to STRING
|
|
# so that cmake -L lists it. The Makefile's cmake-cache-check relies on
|
|
# finding CONFIG in cmake -L output to avoid unnecessary reconfiguration.
|
|
set(CONFIG "${CONFIG}" CACHE STRING "desired configuration" FORCE)
|
|
endif()
|
|
|
|
if(NOT PX4_CONFIG_FILE)
|
|
|
|
file(GLOB_RECURSE board_configs
|
|
RELATIVE "${PX4_SOURCE_DIR}/boards"
|
|
"boards/*.px4board"
|
|
)
|
|
|
|
foreach(filename ${board_configs})
|
|
# parse input CONFIG into components to match with existing in tree configs
|
|
# the platform prefix (eg nuttx_) is historical, and removed if present
|
|
string(REPLACE ".px4board" "" filename_stripped ${filename})
|
|
string(REPLACE "/" ";" config ${filename_stripped})
|
|
list(LENGTH config config_len)
|
|
|
|
if(${config_len} EQUAL 3)
|
|
list(GET config 0 vendor)
|
|
list(GET config 1 model)
|
|
list(GET config 2 label)
|
|
|
|
set(board "${vendor}${model}")
|
|
|
|
# <VENDOR>_<MODEL>_<LABEL> (eg px4_fmu-v2_default)
|
|
# <VENDOR>_<MODEL>_default (eg px4_fmu-v2) # allow skipping label if "default"
|
|
if ((${CONFIG} MATCHES "${vendor}_${model}_${label}") OR # match full vendor, model, label
|
|
((${label} STREQUAL "default") AND (${CONFIG} STREQUAL "${vendor}_${model}")) # default label can be omitted
|
|
)
|
|
set(PX4_CONFIG_FILE "${PX4_SOURCE_DIR}/boards/${filename}" CACHE FILEPATH "path to PX4 CONFIG file" FORCE)
|
|
set(PX4_BOARD_DIR "${PX4_SOURCE_DIR}/boards/${vendor}/${model}" CACHE STRING "PX4 board directory" FORCE)
|
|
set(MODEL "${model}" CACHE STRING "PX4 board model" FORCE)
|
|
set(VENDOR "${vendor}" CACHE STRING "PX4 board vendor" FORCE)
|
|
set(LABEL "${label}" CACHE STRING "PX4 board vendor" FORCE)
|
|
break()
|
|
endif()
|
|
|
|
# <BOARD>_<LABEL> (eg px4_fmu-v2_default)
|
|
# <BOARD>_default (eg px4_fmu-v2) # allow skipping label if "default"
|
|
if ((${CONFIG} MATCHES "${board}_${label}") OR # match full board, label
|
|
((${label} STREQUAL "default") AND (${CONFIG} STREQUAL "${board}")) # default label can be omitted
|
|
)
|
|
set(PX4_CONFIG_FILE "${PX4_SOURCE_DIR}/boards/${filename}" CACHE FILEPATH "path to PX4 CONFIG file" FORCE)
|
|
set(PX4_BOARD_DIR "${PX4_SOURCE_DIR}/boards/${vendor}/${model}" CACHE STRING "PX4 board directory" FORCE)
|
|
set(MODEL "${model}" CACHE STRING "PX4 board model" FORCE)
|
|
set(VENDOR "${vendor}" CACHE STRING "PX4 board vendor" FORCE)
|
|
set(LABEL "${label}" CACHE STRING "PX4 board vendor" FORCE)
|
|
break()
|
|
endif()
|
|
endif()
|
|
endforeach()
|
|
endif()
|
|
|
|
message(STATUS "PX4 config file: ${PX4_CONFIG_FILE}")
|
|
|
|
include_directories(${PX4_BOARD_DIR}/src)
|
|
|
|
set(PX4_BOARD ${VENDOR}_${MODEL} CACHE STRING "PX4 board" FORCE)
|
|
|
|
# board name is uppercase with no underscores when used as a define
|
|
string(TOUPPER ${PX4_BOARD} PX4_BOARD_NAME)
|
|
string(REPLACE "-" "_" PX4_BOARD_NAME ${PX4_BOARD_NAME})
|
|
set(PX4_BOARD_NAME ${PX4_BOARD_NAME} CACHE STRING "PX4 board define" FORCE)
|
|
|
|
set(PX4_BOARD_VENDOR ${VENDOR} CACHE STRING "PX4 board vendor" FORCE)
|
|
set(PX4_BOARD_MODEL ${MODEL} CACHE STRING "PX4 board model" FORCE)
|
|
|
|
set(PX4_BOARD_LABEL ${LABEL} CACHE STRING "PX4 board label" FORCE)
|
|
|
|
set(PX4_CONFIG "${PX4_BOARD_VENDOR}_${PX4_BOARD_MODEL}_${PX4_BOARD_LABEL}" CACHE STRING "PX4 config" FORCE)
|
|
|
|
if(EXISTS "${PX4_BOARD_DIR}/uavcan_board_identity")
|
|
include ("${PX4_BOARD_DIR}/uavcan_board_identity")
|
|
endif()
|
|
|
|
if(EXISTS "${PX4_BOARD_DIR}/sitl.cmake")
|
|
include ("${PX4_BOARD_DIR}/sitl.cmake")
|
|
endif()
|