mirror of
https://github.com/PX4/PX4-Autopilot.git
synced 2026-11-23 07:00:49 +08:00
Tools/ci/ai_review reviews a PR with Claude Code on Amazon Bedrock and writes a pr-review artifact for pr-review-poster.py. - Pipeline: gather (metadata, linked issues, commits, CI status, per-file patches, earlier comments), a reviewer pass returning line findings, PR-level findings and a contribution checklist, an independent validator pass per finding, and code-owned routing: inline only at high confidence, otherwise a before-merge list or a collapsed section. No PR is skipped for size; generated files are listed but not diffed. - Trust: the PR is untrusted data. The agent runs --bare --restricted with read-only tools. Code it writes to check its math runs only in a px4-dev container (no network, no credentials, read-only checkout, gVisor in CI), and `harden` blocks the runner's metadata service first. Output containing a credential is never written. - A model refusal produces no review and passes the provider's exact reason, category and request ID through. - Models and per-role defaults live in models.json; models-check verifies access before switching. - Process checks (tests, description, upgrade notes, docs) live in a CI-only prompt so the interactive skill stays lean. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Ramon Roche <mrpollo@gmail.com>
64 lines
1.6 KiB
Python
64 lines
1.6 KiB
Python
"""GitHub rejects review comments on lines outside the diff, so the
|
|
commentable-line map must match GitHub's view of the new side."""
|
|
|
|
import unittest
|
|
|
|
from ai_review import diff
|
|
|
|
SAMPLE = """\
|
|
diff --git a/src/a.cpp b/src/a.cpp
|
|
index 111..222 100644
|
|
--- a/src/a.cpp
|
|
+++ b/src/a.cpp
|
|
@@ -10,4 +10,5 @@ void f()
|
|
int a = 1;
|
|
-int b = 2;
|
|
+int b = 3;
|
|
+int c = 4;
|
|
return a;
|
|
\\ No newline at end of file
|
|
diff --git a/old.txt b/old.txt
|
|
deleted file mode 100644
|
|
--- a/old.txt
|
|
+++ /dev/null
|
|
@@ -1,2 +0,0 @@
|
|
-gone
|
|
-too
|
|
diff --git a/new.py b/new.py
|
|
new file mode 100644
|
|
--- /dev/null
|
|
+++ b/new.py
|
|
@@ -0,0 +1,2 @@
|
|
+x = 1
|
|
+y = 2
|
|
"""
|
|
|
|
|
|
class TestParse(unittest.TestCase):
|
|
|
|
def setUp(self) -> None:
|
|
self.d = diff.parse(SAMPLE)
|
|
|
|
def test_context_and_added_lines_are_commentable(self) -> None:
|
|
self.assertEqual(self.d.commentable['src/a.cpp'], {10, 11, 12, 13})
|
|
self.assertEqual(self.d.added['src/a.cpp'], {11, 12})
|
|
|
|
def test_new_file(self) -> None:
|
|
self.assertEqual(self.d.commentable['new.py'], {1, 2})
|
|
|
|
def test_deleted_file_has_no_new_side(self) -> None:
|
|
self.assertNotIn('old.txt', self.d.commentable)
|
|
|
|
def test_changed_line_count(self) -> None:
|
|
# a.cpp: 1 removed + 2 added; old.txt: 2 removed; new.py: 2 added
|
|
self.assertEqual(self.d.changed_lines, 7)
|
|
|
|
def test_can_comment_requires_every_line(self) -> None:
|
|
self.assertTrue(self.d.can_comment('src/a.cpp', 11, 12))
|
|
self.assertFalse(self.d.can_comment('src/a.cpp', 13, 14))
|
|
self.assertFalse(self.d.can_comment('missing.cpp', 1, 1))
|
|
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main()
|