UAV-develop/PX4-Autopilot
1
0
Fork 0
mirror of https://github.com/PX4/PX4-Autopilot.git synced 2026-09-24 19:08:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(mavlink): identify files in FTP open failure logs (#28627)

Browse Source 
Failed FTP opens need the requested path and access mode to identify the file behind the error.

Assisted-by: Codex

Signed-off-by: Jacob Dahl <dahl.jakejacob@gmail.com>
This commit is contained in:
Jacob Dahl
2026-09-08 20:25:55 -06:00
committed by GitHub
parent 7b9b22d080
commit ebc4d50a9e
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/modules/mavlink/mavlink_ftp.cpp
View File

@@ -287,6 +287,12 @@ MavlinkFTP::_process_request(
break; break;
} }
if (errorCode == kErrFailErrno && (payload->opcode == kCmdOpenFileRO
|| payload->opcode == kCmdCreateFile || payload->opcode == kCmdOpenFileWO)) {
PX4_ERR("FTP: open '%s' for %s failed: %s", _data_as_cstring(payload),
payload->opcode == kCmdOpenFileRO ? "read" : "write", strerror(_our_errno));
}
out: out:
payload->seq_number++; payload->seq_number++;
@@ -600,7 +606,6 @@ MavlinkFTP::_workOpen(PayloadHeader *payload, int oflag)
} else if (!for_write) { } else if (!for_write) {
_our_errno = errno; _our_errno = errno;
PX4_ERR("stat failed read: %s", strerror(_our_errno));
return kErrFailErrno; return kErrFailErrno;
} }
@@ -609,7 +614,6 @@ MavlinkFTP::_workOpen(PayloadHeader *payload, int oflag)
if (fd < 0) { if (fd < 0) {
_our_errno = errno; _our_errno = errno;
PX4_ERR("open failed: %s", strerror(_our_errno));
return kErrFailErrno; return kErrFailErrno;
} }