From c283d61ef303eeef5907fa628aee268849482c3a Mon Sep 17 00:00:00 2001 From: Lourens Naude Date: Sun, 11 Oct 2026 15:49:50 +0100 Subject: [PATCH] perf(uORB): skip the queue offset division for single-slot topics Assisted-by: Claude:claude-fable-5-1 --- platforms/common/uORB/uORBDeviceNode.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/platforms/common/uORB/uORBDeviceNode.cpp b/platforms/common/uORB/uORBDeviceNode.cpp index f940040410e..bee9c26c7e8 100644 --- a/platforms/common/uORB/uORBDeviceNode.cpp +++ b/platforms/common/uORB/uORBDeviceNode.cpp @@ -194,7 +194,9 @@ uORB::DeviceNode::write(cdev::file_t *filp, const char *buffer, size_t buflen) /* wrap-around happens after ~49 days, assuming a publisher rate of 1 kHz */ unsigned generation = _generation.fetch_add(1); - memcpy(_data + (_meta->o_size * (generation % _meta->o_queue)), buffer, _meta->o_size); + // depth-one topics always use slot 0: skip the division + const size_t offset = (_meta->o_queue > 1) ? (_meta->o_size * (generation % _meta->o_queue)) : 0; + memcpy(_data + offset, buffer, _meta->o_size); // callbacks for (auto item : _callbacks) {