From a34254f5914d4cd05f49ac4697b50ef3e4768172 Mon Sep 17 00:00:00 2001 From: Ubuntu Date: Fri, 20 Nov 2026 18:32:25 +0100 Subject: [PATCH] docs(rover): fix wrong labels in the rover diagrams The throttle setpoint was renamed to the thrust setpoint, the east axis of the pure pursuit diagram was labelled S, the cornering diagram read "Idea Path", and the differential state machine switches on the heading error, not a bearing error. The maximum steer angle is an angle, not a length. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Ubuntu --- docs/assets/config/rover/ackermann_cornering_logic.svg | 2 +- docs/assets/config/rover/differential_state_machine.svg | 2 +- docs/assets/config/rover/pure_pursuit_algorithm.svg | 2 +- docs/assets/config/rover/rover_speed_controller.svg | 2 +- docs/en/config_rover/position_tuning.md | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/assets/config/rover/ackermann_cornering_logic.svg b/docs/assets/config/rover/ackermann_cornering_logic.svg index 6e3fc290862..cb8e55af6e0 100644 --- a/docs/assets/config/rover/ackermann_cornering_logic.svg +++ b/docs/assets/config/rover/ackermann_cornering_logic.svg @@ -1,3 +1,3 @@ -
Current Waypoint
Previous
Waypoint
Next Waypoint
Idea Path
Idea Path
\ No newline at end of file +
Current Waypoint
Previous
Waypoint
Next Waypoint
Ideal Path
Ideal Path
\ No newline at end of file diff --git a/docs/assets/config/rover/differential_state_machine.svg b/docs/assets/config/rover/differential_state_machine.svg index cd00a2d6aae..7215deae336 100644 --- a/docs/assets/config/rover/differential_state_machine.svg +++ b/docs/assets/config/rover/differential_state_machine.svg @@ -1,3 +1,3 @@ -
TURN ON SPOT
DRIVING
Bearing error 
>
RD_TRANS_DRV_TRN
Bearing error>RD_TRANS_DRV_TRN
Bearing error 
< 
RD_TRANS_TRN_DRV
Bearing error<RD_TRANS_TRN_DRV
\ No newline at end of file +
TURN ON SPOT
DRIVING
Heading error 
>
RD_TRANS_DRV_TRN
Heading error>RD_TRANS_DRV_TRN
Heading error 
< 
RD_TRANS_TRN_DRV
Heading error<RD_TRANS_TRN_DRV
\ No newline at end of file diff --git a/docs/assets/config/rover/pure_pursuit_algorithm.svg b/docs/assets/config/rover/pure_pursuit_algorithm.svg index ec554a8acf4..62178d11ef2 100644 --- a/docs/assets/config/rover/pure_pursuit_algorithm.svg +++ b/docs/assets/config/rover/pure_pursuit_algorithm.svg @@ -1,3 +1,3 @@ -
Destination
Start
N
S
S
\ No newline at end of file +
Destination
Start
N
E
E
\ No newline at end of file diff --git a/docs/assets/config/rover/rover_speed_controller.svg b/docs/assets/config/rover/rover_speed_controller.svg index 06bc171fc62..3e95fa17fa0 100644 --- a/docs/assets/config/rover/rover_speed_controller.svg +++ b/docs/assets/config/rover/rover_speed_controller.svg @@ -1,3 +1,3 @@ -
Throttle Setpoint
Throttle Setpoint
Speed Error
Speed Setpoint
Speed Controller
Measured Speed
Vehicle Dynamics
Feed Forward Mapping
+
+
+
-
\ No newline at end of file +
Thrust Setpoint
Thrust Setpoint
Speed Error
Speed Setpoint
Speed Controller
Measured Speed
Vehicle Dynamics
Feed Forward Mapping
+
+
+
-
\ No newline at end of file diff --git a/docs/en/config_rover/position_tuning.md b/docs/en/config_rover/position_tuning.md index bca6b6c010d..00a006f703a 100644 --- a/docs/en/config_rover/position_tuning.md +++ b/docs/en/config_rover/position_tuning.md @@ -127,7 +127,7 @@ $$ | $\vec{a}$ | Vector from current to previous WP | m | | $\vec{b}$ | Vector from current to next WP | m | | $r_{min}$ | Minimum turn radius | m | -| $\delta_{max}$ | Maximum steer angle | m | +| $\delta_{max}$ | Maximum steer angle | rad | | $r_{acc}$ | Acceptance radius | m | ## Differential Rover Only